Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

APP-5314 - add dates and limit to GetRobotPartLogsRequest #538

Merged
merged 5 commits into from
Aug 12, 2024
Merged

APP-5314 - add dates and limit to GetRobotPartLogsRequest #538

Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
a3513c5
update logsRequest
kim-mishra Aug 1, 2024
0b51b77
use valid types
kim-mishra Aug 1, 2024
78bfd10
int32 -> int64
kim-mishra Aug 5, 2024
72e9248
add source to API as per discussion about new control page requirement
kim-mishra Aug 7, 2024
830af9c
Built new protos from 72e9248
github-actions[bot] Aug 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions proto/viam/app/v1/app.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -640,6 +640,10 @@ message GetRobotPartLogsRequest {
optional string page_token = 4;
// logs of all levels are returned when the levels field is empty
repeated string levels = 5;
optional google.protobuf.Timestamp start = 6;
optional google.protobuf.Timestamp end = 7;
Comment on lines +643 to +644
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i thought we decided to not make thse optional?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we decided after doc review to make them optional again so the changes weren't breaking. I wanted to get this PR up and then was going to send an email for the scope update before merging!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah ok great! thanks for clarifying

optional int64 limit = 8;
optional string source = 9;
}

message GetRobotPartLogsResponse {
Expand Down
Loading