APP-5314 - add dates and limit to GetRobotPartLogsRequest #538
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jr22
reviewed
Aug 1, 2024
proto/viam/app/v1/app.proto
Outdated
Comment on lines
643
to
645
| optional google.protobuf.Timestamp start = 6; | ||
| optional google.protobuf.Timestamp end = 7; | ||
| optional int32 limit = 8; |
There was a problem hiding this comment.
any rhyme or reason that you can discern why we use int32 vs int64 in some places?
There was a problem hiding this comment.
no I can't discern any patternbut it should probably be an int64 right? unless you think there is any con to having int64 over int32
jr22
reviewed
Aug 1, 2024
Comment on lines
+643
to
+644
| optional google.protobuf.Timestamp start = 6; | ||
| optional google.protobuf.Timestamp end = 7; |
There was a problem hiding this comment.
i thought we decided to not make thse optional?
There was a problem hiding this comment.
we decided after doc review to make them optional again so the changes weren't breaking. I wanted to get this PR up and then was going to send an email for the scope update before merging!
jr22
approved these changes
Aug 2, 2024
jr22
approved these changes
Aug 7, 2024
kim-mishra
force-pushed
the
APP-5314-aff-dates-and-limit-to-GetRobotPartLogsRequest
branch
from
fe5ac20
to
72e9248
Compare
kim-mishra
added
the
ready-for-protos
kim-mishra
removed
the
ready-for-protos
kim-mishra
deleted the
APP-5314-aff-dates-and-limit-to-GetRobotPartLogsRequest
branch
maxhorowitz
added a commit
that referenced
this pull request
Sep 16, 2024
* main: (22 commits) DATA-3094: Add CLI args to SubmitCustomTrainingJobRequest (#550) bump min golang version (#548) DATA-3054: Added UpdateBoundingBox (#547) RSDK-8595 update docs with new behavior (#546) APP-3604 build endpoints for external oauth and repos (#544) add last updated to fragment proto (#540) APP-5851: Add optional visibility field to `CreateFragmentRequest` (#543) APP-5314 - add dates and limit to GetRobotPartLogsRequest (#538) RSDK-7903 Add unhealthy state and error field (#539) RSDK-8381 add viam server version to API (#537) [APP-5417]: Undo APP-5417 (#536) [APP-5417]: Accommodate pagination for GetRobotPartHistory in api (#535) Data 2816/get training job logs (#534) DATA-2792 - Add URL to UpdateRegistryItemRequest, but make it optional (#532) RSDK-8228 Add config status to machine status API (#531) Add revision field to config (#530) [APP-5420] Add ListMachineFragments request and response (#525) [APP-5400]: Add GetFragmentHistory proto (#524) RSDK-7899 Add MachineStatus to RobotService (#527) RSDK-8083: add LogPatternConfig field to RobotConfig API (#526) ...
maxhorowitz
added a commit
that referenced
this pull request
Sep 16, 2024
* main: (22 commits) DATA-3094: Add CLI args to SubmitCustomTrainingJobRequest (#550) bump min golang version (#548) DATA-3054: Added UpdateBoundingBox (#547) RSDK-8595 update docs with new behavior (#546) APP-3604 build endpoints for external oauth and repos (#544) add last updated to fragment proto (#540) APP-5851: Add optional visibility field to `CreateFragmentRequest` (#543) APP-5314 - add dates and limit to GetRobotPartLogsRequest (#538) RSDK-7903 Add unhealthy state and error field (#539) RSDK-8381 add viam server version to API (#537) [APP-5417]: Undo APP-5417 (#536) [APP-5417]: Accommodate pagination for GetRobotPartHistory in api (#535) Data 2816/get training job logs (#534) DATA-2792 - Add URL to UpdateRegistryItemRequest, but make it optional (#532) RSDK-8228 Add config status to machine status API (#531) Add revision field to config (#530) [APP-5420] Add ListMachineFragments request and response (#525) [APP-5400]: Add GetFragmentHistory proto (#524) RSDK-7899 Add MachineStatus to RobotService (#527) RSDK-8083: add LogPatternConfig field to RobotConfig API (#526) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
API Changes for Improve Cloud Log Management