RSDK-8719: - use maintenance config in RDK #4396
Draft
+242
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viambot
added
the
safe to test
viambot
added
safe to test
viambot
added
safe to test
viambot
added
safe to test
…intenance-reconfige-sensor
viambot
added
safe to test
Kschappacher
commented
Sep 27, 2024
Comment on lines
+1449
to
+1451
| if newConfig.MaintenanceConfig == nil { | ||
| return true, errors.New("maintenanceConfig undefined. Using default reconfigure") | ||
| } |
There was a problem hiding this comment.
move this up to where this is called and don't alert users if this does not exist
| return true, errors.Errorf("maintenanceAllowedKey %s is not a bool value", maintenanceAllowedKey) | ||
| } | ||
|
|
||
| r.logger.Info("maintenanceAllowedKey found canReconfigure set to %t", canReconfigure) |
There was a problem hiding this comment.
maintenanceAllowedKey found on readings from maintenance sensor explicitly say skipping reconfiguration or starting reconfiguration
| errorMessage string | ||
| }{ | ||
| { | ||
| canReconfigure: true, |
| sensor: newSensor(), | ||
| errorMessage: "error getting MaintenanceAllowedKey UnknownKey from sensor reading", | ||
| }, | ||
| } |
There was a problem hiding this comment.
add test for non boolean return
| } | ||
|
|
||
| func (r *localRobot) checkMaintenanceSensorReadings(maintenanceAllowedKey string, sensor resource.Sensor) (bool, error) { | ||
| readings, err := sensor.Readings(context.Background(), map[string]interface{}{}) |
There was a problem hiding this comment.
add context timeout here and add test for the timeout
10zingpd
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature