-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RSDK-8719: - use maintenance config in RDK #4396
Merged
Kschappacher
merged 26 commits into
viamrobotics:main
from
Kschappacher:RSDK-8167-enable-maintenance-reconfige-sensor
Oct 15, 2024
Merged
Changes from all commits
Commits
Show all changes
26 commits
Select commit
Hold shift + click to select a range
6614ddf
first pass
Kschappacher 984b765
clean up errors
Kschappacher 43e8cd9
lint
Kschappacher a2b0b48
fix tests and lint
Kschappacher 8964051
lint
Kschappacher 33aec5b
Merge remote-tracking branch 'upstream/main' into RSDK-8167-enable-ma…
Kschappacher ad3eff8
add timeout and proto conversions
Kschappacher 3ac4051
fix timeout
Kschappacher 7660bba
add remote testings
Kschappacher b20cfda
clean up code
Kschappacher c3b2410
Merge remote-tracking branch 'upstream/main' into RSDK-8167-enable-ma…
Kschappacher b11af36
lint and clean up code
Kschappacher 20aae80
Merge remote-tracking branch 'upstream/main' into RSDK-8167-enable-ma…
Kschappacher 10ebeeb
address pr comments
Kschappacher 7653ecc
Merge remote-tracking branch 'upstream/main' into RSDK-8167-enable-ma…
Kschappacher acd77e0
address pr comments, move config revision to after reconfig blocker
Kschappacher f4effb4
update tests
Kschappacher 7ae8e32
add nil check
Kschappacher 98f69d3
Update robot/impl/local_robot.go
Kschappacher c7f5cfc
Update robot/impl/local_robot.go
Kschappacher 443ca6d
Update robot/impl/local_robot.go
Kschappacher 62e51aa
remove dup
Kschappacher 15bcb78
Merge branch 'RSDK-8167-enable-maintenance-reconfige-sensor' of ssh:/…
Kschappacher f8a58d9
add test cases and ensure readings work after going to proto and back
Kschappacher 36a788b
clean up dif
Kschappacher b70a0a7
fix log names
Kschappacher File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for encoding rules here. Some questions:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I buy that they all just "work" without much changes. How does this one happen?
I wasn't aware that we had any special logic around fragments.
SGTM; as long as that's captured in some eventual fleet ticket.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ahh forgot to mention the fragments. The logic for that is in the frontend when we apply a fragment to a config. so I guess the logic is spread out even more 😅
Also 👍 will add it to the front end ticket