-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for multiple EXT-X-MAP tags #3312
Conversation
Hello, here is a sliding window m3u8 which contains new EXT-X-MAP (so it includes 2) after every discontinuity (about every 3 to 4 minutes) |
Looks OK to me. Is it supposed to be video-only? There is no planned release date for v0.15.0. I can merge this but would very much like to see the same/similar changes made and tested against master/latest v1 rc. |
Yes, this stream is video-only. Looking forward to having this fix in 1.0 to get fMP4 ad insertion support |
@robwalch @erkreutzer How to move this along? A new PR against master? |
Yes. This PR surpassed the earlier one against master, but 0.15 is on-hold indefinitely. Merging this and porting the changes to head would be a lot for me, especially while tackling regressions and responding to incoming issues. A new PR against master@v1.0.1+ with sample streams would go a long way to getting this into an upcoming release sooner. |
@robwalch Alright I've got something in progress here that seems to work so far here: https://github.com/elv-peter/hls.js/tree/v1.0.1/bugfix/multi-ext-x-map-init. I temporarily commented out some code that loads a SIDX URL. Do you know what |
Should be able to close this now |
This PR will...
Support multiple
EXT-X-MAP
tags (a slightly updated version of #2279)Why is this Pull Request needed?
To fix #1990 and support playlists that have multiple
EXT-X-MAP
tags.I've verified with some private streams and also using the demo stream from the original issue (~12 seconds time offset): https://storage.googleapis.com/gaetan/hls.js/master-fmp4-bug.m3u8
Are there any points in the code the reviewer needs to double check?
Per the old PR there was a comment regarding keeping the
levelDetails.initSegment
property up to date. I've addressed what I believe the feedback to be, but may have missed the intent of the comment.Resolves issues:
#1990
Checklist