Add support for multiple EXT-X-MAP tags (updated) #3859
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will...
Support multiple
EXT-X-MAP
tags. I modified #3312 work on the current master (tag v1.0.2)Why is this Pull Request needed?
Fix #1990 (Broken playback with multiple EXT-X-MAP in fmp4 HLS). That is, this allows splicing multiple videos together with discontinuities.
Verified with https://storage.googleapis.com/gaetan/hls.js/master-fmp4-bug.m3u8 (that it cuts to the commercial and back)
Are there any points in the code the reviewer needs to double check?
Instead of having one global init segment in
LevelDetails
, I gave each segment/fragment a pointer to its init segment (EXT-X-MAP
declares the init segment for all subsequent media segments until the nextEXT-X-MAP
)Resolves issues:
#1990
Checklist