feat: fetch mpd/dash playlists too #35

brandonocasey · 2019-07-18T15:40:57Z

Closes #34

package.json

src/walk-manifest.js

brandonocasey · 2019-07-18T15:46:09Z

src/walk-manifest.js

      requestRetryDelay = 5000
    } = options;

    let resources = [];
-    const manifest = {};
+    const manifest = {parent};


dash needs access to the parent manifest on child playlists

brandonocasey · 2019-07-18T15:47:28Z

src/walk-manifest.js

@@ -147,125 +168,160 @@ const walkPlaylist = function(options) {
      visitedUrls = [],
      requestTimeout = 1500,
      requestRetryMaxAttempts = 5,
+      dashPlaylist = null,


In mpd-parser we really only mock child playlists. So if we see dashPlaylist here we know:

That this playlist won't have a uri, or anything to download

That this playlist has already been parsed

src/walk-manifest.js

brandonocasey · 2019-07-18T15:48:54Z

src/walk-manifest.js

-        resources.push(manifest);
-        visitedUrls.push(manifest.uri);
+    if (dashPlaylist) {
+      requestPromise = Promise.resolve({statusCode: 200});


only request when needed.

brandonocasey · 2019-07-18T15:49:04Z

src/walk-manifest.js

+
+      let dash;
+
+      if (!dashPlaylist) {


only parse when needed.

brandonocasey · 2019-07-18T15:49:38Z

src/write-data.js

@@ -68,15 +68,15 @@ const WriteData = function(decrypt, concurrency, resources) {
      operations.push(function() {
        return writeFile(r.file, r.content);
      });
-    } else if (r.key && decrypt) {
+    } else if (r.uri && r.key && decrypt) {


ignore any file that does not have a uri, such as dash playlists.

gkatsev · 2019-08-30T20:02:58Z

Looks like this works for simple mpds, it didn't work for the SIDX mpd that we have linked in VHS master.
Also, seems like decryption is broken?

brandonocasey · 2019-08-30T22:06:31Z

Fixed the sidx case and decryption, seems like aes-decrypter expects a Uint8Array and not an ArrayBuffer, not sure when this happened.

brandonocasey · 2019-09-05T18:46:14Z

src/write-data.js

      if (err) {
        return reject(err);
      }
-      return resolve(new Buffer(bytes));
+      return resolve(Buffer.from(bytes));


new Buffer is deprecated in current nodejs and this is now the reccomended usage.

brandonocasey · 2019-09-05T18:46:32Z

src/write-data.js

 };

 const decryptFile = function(content, encryption) {
  return new Promise(function(resolve, reject) {
    /* eslint-disable no-new */
    // this is how you use it, its kind of bad but :shrug:
-    new AesDecrypter(toArrayBuffer(content), encryption.bytes, encryption.iv, function(err, bytes) {
+    new AesDecrypter(toUint8Array(content), encryption.bytes, encryption.iv, function(err, bytes) {


AesDecrypter expects a Uint8Array

brandonocasey · 2019-09-05T18:46:51Z

src/write-data.js

-  }
-  return ab;
+const toUint8Array = function(nodeBuffer) {
+  return new Uint8Array(nodeBuffer.buffer, nodeBuffer.byteOffset, nodeBuffer.byteLength / Uint8Array.BYTES_PER_ELEMENT);


nodes Buffer object to Uint8Array.

gkatsev

SIDX and decryption is working now. LGTM.