Double captions in Chrome

[heff]

If you go to the Video.js homepage with the latest version of Chrome (27), you'll see the captions playing without clicking the captions button. If you then turn on the captions, there will be two sets of captions, the vjs custom captions and Chrome's built-in captions.

There seems to have been and update to Chrome that is causing the captions to show by default, even though the 'default' attribute isn't being used on any of the tracks. This at least wasn't happening when we launched the new site at the beginning of may.

This is different from #259, where captions would show twice when the default attribute was used.

[nosecreek]

I also noticed that this was not an issue when version 4 was initially released, but is now. Also, I've gone back and tested Video.js 3 and the issue is not present there.

[heff]

It's not present? That's interesting. I can't think of anything that would've changed in 4.0 around that, but I guess something must have.

[vagari]

I can confirm it's also present in Chrome Canary (29.0.1547.2) so it'll be around for a while.

[vagari]

Found a post involving Chromium that seems to have a solution. I actually just threw this into a web page right under the video element (where I already had a script element performing some other actions).

var vidz = document.getElementsByTagName('video');
for (var i = 0, j = vidz.length; i < j; i++) {
    vidz[i].textTracks[0].mode = "hidden";
};

Hopefully something comparable can be implemented within the actual source (I'm guessing something does already exist, it's just not working with Chrome).

This works on Chrome v. 27 and the previously mentioned Canary.

[heff]

This is what originally fixed the issue in Chrome.

video.js/src/js/player.js

Line 154 in 85c6b46

tag.removeChild(j[0]);

Chrome must be parsing the tag data quicker now, so removeChild isn't enough to kill the default tags. Simply breaking that out to check for tags specifically and setting the mode to hidden should fix that issue.

It should probably be done with #511 in consideration.