Move manual events into tech controller #1417
Conversation
Migrate the timers that manage creating timeupdate and progress events when the tech doesn't support them natively. Now, techs that extend MediaTechController will continue to automatically pick up synthetic playback and buffering events but they're scoped much more closely to the entity that needs them. In addition, time and progress tracking have been moved much earlier into the component initialization which fixes videojs#1414.
The major browsers that support HTML video now reliably support progress events, so don't worry about synthesizing them for HTML anymore.
Pick up updated flash compiler settings.
| @@ -69,7 +69,9 @@ test('currentTime is the seek target during seeking', function() { | |||
| parentEl = document.createElement('div'), | |||
| tech = new vjs.Flash({ | |||
| id: noop, | |||
There was a problem hiding this comment.
I'm aware of the test player. When there's not too much mocking to be done, I think doing it inline makes the dependencies on the player more explicit and saves the reader from digging around to figure out what a test player actually provides. It does lead to a couple extra lines and some duplication in the tests, though. I'm happy to use the test player utility all the time if that's what you'd prefer.
There was a problem hiding this comment.
I can see that, and it's better to run as little code that's not required as possible. But it gets bulky and repetitive. Also the majority of the method stubs aren't directly related to the test itself. They tend to be the same across a group of tests, and ID is currently needed by every component. Any in between solutions?
|
merged in |
Rebased #1415 against stable.