Automatic cleanup of listeners on other components #1588
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented half of #1544. Now instead of using:
You can use:
Using the second form will automatically clean up the listener whenever either the player or the component is disposed. And 'player' can be replaced with any other component.
When implementing this in existing components I found a few places we weren't removing listeners on dispose, and they should be fixed now with this.
UPDATED to include other elements, e.g.