Abort vjs.trigger when "elem" param is invalid #1610
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #1484
vjs.hasData throws a fit (exception) and aborts the whole process when the "elem" param of vjs.trigger is null or undefined.
That easily broke testing with Karma.
It was discovered in Karma-jasmine tests LoveIsGrief/videojs-soundcloud/test/unit/main-spec.coffee#72. A new player is created in the
beforeEach
and disposed of inafterEach
.This is just treating the symptom, not cause, but I need it nonetheless to run the tests.
Cheers