Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test using BrowserStack #2492

Closed
wants to merge 2 commits into from
Closed

Conversation

forbesjo
Copy link
Contributor

This PR is to run the unit tests using BrowserStack because BrowserStack seems faster/more stable than Sauce Labs.

BROWSER_STACK_USERNAME and BROWSER_STACK_ACCESS_KEY need to be exported in Travis.
There also needs to be a mention of BrowserStack in the README or website to use the open source subscription.

@heff
Copy link
Member

heff commented Aug 19, 2015

Seems straight forward enough. Have you tried IE8 with this at all?

There also needs to be a mention of BrowserStack in the README

Want to add something to the readme as part of this?

Add BrowserStack mention to README
@forbesjo
Copy link
Contributor Author

IE's are good to go and added the mention

@forbesjo
Copy link
Contributor Author

@mmcc
Copy link
Member

mmcc commented Aug 20, 2015

The timeouts in that demo build make me sad.

@heff
Copy link
Member

heff commented Aug 20, 2015

It's weird because all the browsers seem to have run the tests except for IE9. I wonder if we fixed those vjs_getProp errors if the suite would pass, without IE9 that is.

@forbesjo
Copy link
Contributor Author

IE9 crashes when I try to view the qunit test page, when I skip that browser I don't see any disconnects. See https://travis-ci.org/forbesjo/vjs-browserstack-demo/builds/76531261

@heff
Copy link
Member

heff commented Aug 20, 2015

Strange that removing one browser stopped the disconnects in the rest. Also
we really need to clean up all those VIDEOJS error logs.

I'm working on adding the browser stack credentials to travis.

On Thu, Aug 20, 2015 at 2:05 PM, forbesjo notifications@github.com wrote:

IE9 crashes when I try to view the qunit test page, when I skip that
browser I don't see any disconnects. See
https://travis-ci.org/forbesjo/vjs-browserstack-demo/builds/76531261


Reply to this email directly or view it on GitHub
#2492 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants