Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed tracks test by switching to a fake tech #2496

Closed
wants to merge 1 commit into from

Conversation

heff
Copy link
Member

@heff heff commented Aug 21, 2015

See #2492 and errors in https://travis-ci.org/forbesjo/vjs-browserstack-demo/builds/76509552

@gkatsev would this approach still be testing what we need it to, or are we testing nothing now?

@gkatsev
Copy link
Member

gkatsev commented Aug 21, 2015

I guess the question is whether it would unload the old tech faker and re-load it like switching between a real tech would be? Maybe we can switch from the Html5 tech to the TechFaker tech?

@heff
Copy link
Member Author

heff commented Aug 24, 2015

Yeah, there is a check to see if the same tech type is already loaded, but that happens in sourceList_, before loadTech. loadTech should always unload/load, so we should be ok there, as long as there's nothing special it's expecting the tech to do.

I'd like to avoid using even the HTML5 tech in tests that run on all platforms.

@gkatsev
Copy link
Member

gkatsev commented Aug 24, 2015

Ok. That's fine by me then. I just wasn't certain whether calling loadTech with the same tech would actually be testing what we want.

@heff heff closed this in f7d1289 Aug 24, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants