Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs changes #2781

Closed
wants to merge 2 commits into from
Closed

Docs changes #2781

wants to merge 2 commits into from

Conversation

vitorf7
Copy link
Contributor

@vitorf7 vitorf7 commented Nov 5, 2015

  • Change all mentions of javascript language to js in order to be consistent everywhere across the docs
  • Add js code syntax in plugins.md as the code was not encapsulated inside the code syntax
  • Change CDN videojs version for the setup.md guide to the latest version of 5.1.0

@vitorf7
- Change all mentions of javascript language to js in order to be con…
c2ecec0 
…sistent everywhere across the docs

- Add js code syntax in plugins.md as the code was not encapsulated inside the code syntax
- Change CDN videojs version for the setup.md guide to the latest version of 5.1.0
@gkatsev
Copy link
Member

gkatsev commented Dec 3, 2015

Thanks. Though, unfortunately, the version is out of date again :)

gkatsev
gkatsev reviewed Dec 3, 2015
View reviewed changes
docs/guides/setup.md
@@ -14,8 +14,8 @@ You can download the Video.js source and host it on your own servers, or use the

### CDN Version ###
```html
<link href="//vjs.zencdn.net/4.12/video-js.min.css" rel="stylesheet">
<script src="//vjs.zencdn.net/4.12/video.min.js"></script>
<link href="//vjs.zencdn.net/5.1.0/video-js.min.css" rel="stylesheet">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a thing linking to http://videojs.com/getting-started/ saying that you can always get the latest URL there?

@gkatsev gkatsev added patch This PR can be added to a patch release. needs: LGTM Needs one or more additional approvals labels Dec 3, 2015
@gkatsev
Copy link
Member

gkatsev commented Dec 3, 2015

one comment, LGTM otherwise.

@vitorf7
Copy link
Contributor Author

vitorf7 commented Jan 18, 2016

@gkatsev Really sorry for the late response I got swamped at work. Do you mean adding the link in the setup.md?

@vitorf7
Update setup.md
d9325d8 
Make changes to setup.md to update the version of video js CDN to latest as well as add link to http://videojs.com/getting-started/ as suggested by gkatsev
@gkatsev
Copy link
Member

gkatsev commented Jan 18, 2016

LGTM. Thanks!

@gkatsev gkatsev added confirmed and removed needs: LGTM Needs one or more additional approvals labels Jan 18, 2016
@gkatsev gkatsev closed this in 9cdfb75 Jan 26, 2016
jgubman added a commit to jgubman/video.js that referenced this pull request Jan 27, 2016
@jgubman
Merge branch 'master' of https://github.com/videojs/video.js into stable
37d60dc 
* 'master' of https://github.com/videojs/video.js: (38 commits)
  v5.6.0
  @gkatsev updated to latest videojs-ie8 shim. closes videojs#3042
  @hubdotcom changed URLs in README to be protocol-relative. closes videojs#3040
  @CoWinkKeyDinkInc fixed table in Tracks guide. Replaced some single quotes with double quotes. closes videojs#2946
  @aril-spetalen added language support for Norwegian (nb and nn). closes videojs#3021
  @vitor-faiante updated the guides. closes videojs#2781
  @gkatsev checked muted status when updating volume bar level. closes videojs#3037
  @OwenEdwards fixed double-localization of mute toggle control text. closes videojs#3017
  @mister-ben made $primary-foreground-color a !default sass var. closes videojs#3003
  @OwenEdwards Fixed volume menu keyboard access. closes videojs#3034
  @OwenEdwards Fixed menu keyboard access and ARIA labeling for screen readers. closes videojs#3033
  @OwenEdwards added ClickableComponent. Fixed keyboard operation of buttons. closes videojs#3032
  v5.5.3
  @rcrooks fixed a couple of docs link and a jsdoc comment. closes videojs#2987
  @mister-ben updated CDN urls in setup guide. closes videojs#2984
  @gkasev updated vjs to correctly return already created player when given an element. closes videojs#3006
  v5.5.2
  make sure that styleEl_ is in DOM before removing on dispose. closes videojs#3004
  v5.5.1
  @gkatsev fixed sass if else for icons. closes videojs#2988
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
confirmed patch This PR can be added to a patch release.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vitorf7 @gkatsev