Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CDN URL in setup guide #2984

Closed
wants to merge 1 commit into from

Conversation

mister-ben
Copy link
Contributor

The setup guide has broken links to non-existent 4.12 files. This updates the URL to 5.4.6.

Longer term, what's the best way to keep the markdown docs updated?

@gkatsev
Copy link
Member

gkatsev commented Jan 8, 2016

LGTM.

@gkatsev gkatsev added confirmed documentation patch This PR can be added to a patch release. labels Jan 8, 2016
@gkatsev gkatsev closed this in c901fce Jan 15, 2016
jgubman added a commit to jgubman/video.js that referenced this pull request Jan 27, 2016
* 'master' of https://github.com/videojs/video.js: (38 commits)
  v5.6.0
  @gkatsev updated to latest videojs-ie8 shim. closes videojs#3042
  @hubdotcom changed URLs in README to be protocol-relative. closes videojs#3040
  @CoWinkKeyDinkInc fixed table in Tracks guide. Replaced some single quotes with double quotes. closes videojs#2946
  @aril-spetalen added language support for Norwegian (nb and nn). closes videojs#3021
  @vitor-faiante updated the guides. closes videojs#2781
  @gkatsev checked muted status when updating volume bar level. closes videojs#3037
  @OwenEdwards fixed double-localization of mute toggle control text. closes videojs#3017
  @mister-ben made $primary-foreground-color a !default sass var. closes videojs#3003
  @OwenEdwards Fixed volume menu keyboard access. closes videojs#3034
  @OwenEdwards Fixed menu keyboard access and ARIA labeling for screen readers. closes videojs#3033
  @OwenEdwards added ClickableComponent. Fixed keyboard operation of buttons. closes videojs#3032
  v5.5.3
  @rcrooks fixed a couple of docs link and a jsdoc comment. closes videojs#2987
  @mister-ben updated CDN urls in setup guide. closes videojs#2984
  @gkasev updated vjs to correctly return already created player when given an element. closes videojs#3006
  v5.5.2
  make sure that styleEl_ is in DOM before removing on dispose. closes videojs#3004
  v5.5.1
  @gkatsev fixed sass if else for icons. closes videojs#2988
  ...
@mister-ben mister-ben deleted the setup-guide-version branch August 10, 2016 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
confirmed documentation patch This PR can be added to a patch release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants