Disable HLS hack on Firefox for Android #3498
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The tests need to be fixed, but this lets videojs-contrib-hls work on Android FF too. |
|
Ah, yeah, the two tests just set |
|
I've opened #3586, it contains the changes from this PR + fix for the tests + a new test for Firefox for Android. |
|
Closing in favor of #3586. That PR will get merged as two commits to give credit to both @kentuckyfriedtakahe and @marco-c. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Chrome reports HLS is not supported when it actually so a hack was added to work around it. Contrastingly Firefox for Android actually doesn't support HLS. This fixes the Firefox compat bug https://bugzilla.mozilla.org/show_bug.cgi?id=1194662
Specific Changes proposed
Firefox for Android will use alternative fallbacks if they are available rather than hitting a dead end.