Disable HLS hack on Firefox for Android (with tests) #3586
Conversation
|
|
||
| assert.strictEqual(video.canPlayType, | ||
| canPlayType, | ||
| 'original canPlayType and patched canPlayType should not be equal'); |
There was a problem hiding this comment.
Looks like the assertion message needs to be updated.
There was a problem hiding this comment.
Leftover from copy & paste of the other test, fixed in b762008.
misteroneill
added
patch
|
Thanks for this, @marco-c! LGTM |
misteroneill
added
needs: LGTM
|
LGTM. We should merge this in as two separate commits when we get around to it. |
brandonocasey
added
confirmed
and removed
needs: LGTM
| @@ -1319,7 +1319,7 @@ const mp4RE = /^video\/mp4/i; | |||
|
|
|||
| Html5.patchCanPlayType = function() { | |||
| // Android 4.0 and above can play HLS to some extent but it reports being unable to do so | |||
| if (browser.ANDROID_VERSION >= 4.0) { | |||
| if (browser.ANDROID_VERSION >= 4.0 && !browser.IS_FIREFOX) { | |||
There was a problem hiding this comment.
I just saw an update to the firefox beta which said they're getting HLS support. Is this something that we should possibly account for? Maybe check if firefox version is less than 50?
There was a problem hiding this comment.
The support in Firefox 50 is not polished, there are a lot of bugs (e.g. https://bugzilla.mozilla.org/show_bug.cgi?id=1301050). It will probably be disabled in 50.
We're using a hacky solution, so it will never be like a properly supported codec.
I would leave it as is and expect Firefox not to return wrong values in canPlayType, if it will ever support HLS natively, it will be returned in canPlayType.
There was a problem hiding this comment.
I guess we could also always update this at a later time once/if it officially ships.
|
Any idea when this will land in the core JS that Brightcove serves with its players? (e.g. http://players.brightcove.net/659677170001/default_default/index.js) Right now, that file references Video.js version 5.11.7. |
#3498 + tests.