Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(player): cache_.currentTime is not updated when the current time is set #8285

Merged
merged 2 commits into from
Jun 1, 2023
Merged

fix(player): cache_.currentTime is not updated when the current time is set #8285

merged 2 commits into from
Jun 1, 2023

Commits on May 20, 2023

  1. refactor(player): decrease the indentation level in the currentTime m… 

    …ethod
    @amtins
    amtins committed May 20, 2023
    Configuration menu
    Copy the full SHA
    d9884c1 View commit details
    Browse the repository at this point in the history

  2. fix(player): cache_.currentTime is not updated when the current time … 

    …is set

Updating cache_.currentTime as soon as the currentTime is set avoids having to wait for the timeupdate event, which results in:

- making cache_.currentTime more reliable
- updating the progress bar on mouse up after dragging when the media is paused.

See also: videojs#6232, videojs#6234, videojs#6370, videojs#6372
    @amtins
    amtins committed May 20, 2023
    Configuration menu
    Copy the full SHA
    7fa7336 View commit details
    Browse the repository at this point in the history