Mark throwable methods as pure #3171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This works probably because it is not parsed by PHP but by something more tolerant, but let's make it more valid (the final access type in the signature is not valid) PHP anyway, that will raise fewer eyebrows.
|
Some of the failing tests look like they are cause by my changes, I have to look into that. |
Exception is the only possible class implementation of Throwable, and all of its methods except __toString() are final. See https://github.com/php/php-src/blob/ca006e54e30bc5ac96f35af1ed7fd73a8c422cf0/Zend/zend_exceptions.stub.php#L3-L25 Closes vimeo#3170
greg0ire
force-pushed
the
mark-throwable-methods-as-pure
branch
from
a96fe6a
to
4fee755
Compare
|
Thanks! Looks like the failures were just due to my earlier bad merge |
andrew-demb
reviewed
Apr 18, 2020
| */ | ||
| public final function getCode(){} | ||
| public final function getCode(): int {} |
There was a problem hiding this comment.
getCode() can return string
There was a problem hiding this comment.
There was a problem hiding this comment.
Yes. PDO throw exceptions with string codes.
https://3v4l.org/lP7cb
https://www.php.net/manual/en/exception.getcode.php
There was a problem hiding this comment.
Indeed. WTF… a PR is on its way.
There was a problem hiding this comment.
See fix here: #3175
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.