Account for PDOException #3175
Merged
Account for PDOException #3175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Probably for legacy reasons, PDOException::getCode() can return string (it's an SQLSTATE code). Note that if you instantiate it yourself, you will get an integer though. I changed the signature of the Exception stub accordingly, and then there were errors about incompatible signatures, so I had to change the signature of Throwable too, which makes sense since a Throwable could be a PDOException. The signature at https://www.php.net/manual/en/throwable.getcode.php seems plain wrong, and that same page of the docs warns about PDOException. Not sure what are the plans for future versions of PHP.
greg0ire
force-pushed
the
get-code-mixed
branch
from
84a15e6
to
53cd878
Compare
I rebased since then, and it no longer happens, what should I do? I think it makes sense since |
|
Yeah, this is correct – getCode doesn't have to return an |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Probably for legacy reasons, PDOException::getCode() can return string (it's an
SQLSTATE code). Note that if you instantiate it yourself, you will get
an integer though.
I changed the signature of the Exception stub accordingly, and then
there were errors about incompatible signatures, so I had to change the
signature of Throwable too, which makes sense since a Throwable could be
a PDOException. The signature at
https://www.php.net/manual/en/throwable.getcode.php seems plain wrong,
and that same page of the docs warns about PDOException. Not sure what
are the plans for future versions of PHP.