GPU Aggregation (2/8): GPUAggregator #8887
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pessimistress
force-pushed
the
x/aggregation-2
branch
2 times, most recently
from
7af1d75
to
21358eb
Compare
felixpalmer
approved these changes
May 16, 2024
...es/aggregation-layers/src/aggregation-layer-v9/gpu-aggregator/webgl-aggregation-transform.ts
Outdated
Show resolved
Hide resolved
| } | ||
|
|
||
| dimensions: 1 | 2; | ||
| numChannels: 1 | 2 | 3; |
There was a problem hiding this comment.
Could we make the Aggregator class generic on the number of channels? That way we could catch out of bounds access at compile time, e.g.
type 3Channel = 0 | 1 | 2;
new GPUAggregator<3Channel>(...)
getResult(channel: Channels)
...es/aggregation-layers/src/aggregation-layer-v9/gpu-aggregator/webgl-aggregation-transform.ts
Show resolved
Hide resolved
...es/aggregation-layers/src/aggregation-layer-v9/gpu-aggregator/webgl-aggregation-transform.ts
Show resolved
Hide resolved
modules/aggregation-layers/src/aggregation-layer-v9/gpu-aggregator/webgl-bin-sorter.ts
Show resolved
Hide resolved
modules/aggregation-layers/src/aggregation-layer-v9/gpu-aggregator/webgl-bin-sorter.ts
Show resolved
Hide resolved
test/modules/aggregation-layers/aggregation-layer-v9/gpu-aggregator.spec.ts
Outdated
Show resolved
Hide resolved
Pessimistress
force-pushed
the
x/aggregation-1
branch
from
af9e3ff
to
dd55918
Compare
Pessimistress
force-pushed
the
x/aggregation-2
branch
from
21358eb
to
c49810a
Compare
Pessimistress
force-pushed
the
x/aggregation-2
branch
2 times, most recently
from
7984f42
to
c6fae8c
Compare
Pessimistress
force-pushed
the
x/aggregation-2
branch
from
c6fae8c
to
a9f0504
Compare
donmccurdy
reviewed
Jun 10, 2024
modules/aggregation-layers/src/aggregation-layer-v9/gpu-aggregator/gpu-aggregator.ts
Outdated
Show resolved
Hide resolved
modules/aggregation-layers/src/aggregation-layer-v9/gpu-aggregator/gpu-aggregator.ts
Outdated
Show resolved
Hide resolved
modules/aggregation-layers/src/aggregation-layer-v9/gpu-aggregator/gpu-aggregator.ts
Outdated
Show resolved
Hide resolved
donmccurdy
reviewed
Jun 10, 2024
Comment on lines
44
to
45
| /** An Aggregator implementation that calculates aggregation on the GPU */ | ||
| export class GPUAggregator implements Aggregator { |
There was a problem hiding this comment.
Given that GPU aggregation looks very different in WebGPU ... do we see GPUAggregator as generalizing over WebGL and WebGPU? Or should there be separate WebGLAggregator vs. WebGPUAggregator classes?
Apologies if I've missed or forgotten a prior thread on this, and please ignore this if it's going to distract from progress on this great stack of PRs. :)
There was a problem hiding this comment.
The plan is to have a separate class for WebGPU. I agree this should be called WebGLAggregator.
donmccurdy
approved these changes
Jun 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #7457
Change List
GPUAggregator