Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GPU Aggregation (2/8): GPUAggregator #8887
GPU Aggregation (2/8): GPUAggregator #8887
Changes from 5 commits
c6da5cf
2af6015
1b3cf9e
2f790c7
a9f0504
aa8b3fd
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Given that GPU aggregation looks very different in WebGPU ... do we see GPUAggregator as generalizing over WebGL and WebGPU? Or should there be separate WebGLAggregator vs. WebGPUAggregator classes?
Apologies if I've missed or forgotten a prior thread on this, and please ignore this if it's going to distract from progress on this great stack of PRs. :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The plan is to have a separate class for WebGPU. I agree this should be called WebGLAggregator.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we make the
Aggregator
class generic on the number of channels? That way we could catch out of bounds access at compile time, e.g.Check warning on line 147 in modules/aggregation-layers/src/aggregation-layer-v9/gpu-aggregator/gpu-aggregator.ts
GitHub Actions / test-node