fix: Sorting issues

[bprusinowski]

Fixes #1057.
Fixes #1054.
Fixes #1053.

For the line chart legend ordering issues, we were not using getSortingOrders helper function, which lead to orderBy function not using right order for subsequent sorting functions.

For the table sorting problems, we were:

• expecting that a value will always have either identifier or position (which in not always the case, e.g. for TemporalDimensions) and filtering out such values in makeDimensionValueSorters. This led to broken table sort when sorting e.g. TemporalDimensions. @ptbrowne do you remember why such filtering was introduced in the first place?
• sorting NumericalMeasures by labels. As we only fetch min and max value for such dimensions, this led to broken sorting logic for every NumericalMeasure (and when the label was there, we were treating it as string, while is should have been treated as number). This PR fixes that issue by returning an identity function (almost, converting string to number) for NumericalMeasures.

How to test

Re-create the charts defined in the issue to see that the sorting works correctly now.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
visualization-tool	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jun 6, 2023 11:44am

[ptbrowne]

Code changes all look OK to me ! Thanks @bprusinowski ! Do you think we could add a test for the nominal values sorting ?

[ptbrowne]

@ptbrowne do you remember why such filtering was introduced in the first place?

Sadly, I do not remember why there was a sorting on identifier or position in the first place.

[bprusinowski]

@ptbrowne I've added two tests for nominal and measure dimensions 👍

[sosiology]

@ptbrowne do you remember why such filtering was introduced in the first place?

Sadly, I do not remember why there was a sorting on identifier or position in the first place.

Maybe this @bprusinowski #821