Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Order for sorting is position / identifier #821

Merged
merged 2 commits into from
Nov 4, 2022

Conversation

ptbrowne
Copy link
Collaborator

@ptbrowne ptbrowne commented Nov 3, 2022

When ordering segment, "position" has priority over "identifier".

fix #580
fix #820

@vercel
Copy link

vercel bot commented Nov 3, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
visualization-tool ✅ Ready (Inspect) Visit Preview Nov 4, 2022 at 11:54AM (UTC)

Copy link
Collaborator

@bprusinowski bprusinowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Cool catch related to the "asc" & "desc" array filling ;)

@ptbrowne ptbrowne force-pushed the fix/order-position-identifier branch from 960d25a to f56f925 Compare November 4, 2022 11:49
@ptbrowne ptbrowne merged commit 094f5f0 into main Nov 4, 2022
@ptbrowne ptbrowne deleted the fix/order-position-identifier branch November 4, 2022 11:52
@sosiology sosiology mentioned this pull request Jun 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants