fix: when the file path is an absolute path, parsing causes parameter loss

[yzydeveloper]

Description

Fixes #10448

When the file path is an absolute path

For example E:/_yzydeveloper/vite-resolve-url-encode/node_modules/@ui/components/Test.vue?vue&type=template&lang.js

new URL will resolve to

URL {
  href: 'e:/_yzydeveloper/vite-resolve-url-encode/node_modules/@ui/components/Test.vue?vue&type=template&lang.js',
  origin: 'null',
  protocol: 'e:',
  username: '',
  password: '',
  host: '',
  hostname: '',
  port: '',
  pathname: '/_yzydeveloper/vite-resolve-url-encode/node_modules/@ui/components/Test.vue',
  search: '?vue&type=template&lang.js',
  searchParams: URLSearchParams { 'vue' => '', 'type' => 'template', 'lang.js' => '' },
  hash: ''
}

The protocol at this time is e:,caused pathToFileURL processing error,cause parameter loss.

error handling

export function injectQuery(url: string, queryToInject: string): string {
  // ...
  if (resolvedUrl.protocol !== 'relative:') {
    resolvedUrl = pathToFileURL(url)
  }
  // ...
}

normal handling

export function injectQuery(url: string, queryToInject: string): string {
  // ...
  if (resolvedUrl.protocol === 'file:') {
    resolvedUrl = pathToFileURL(url)
  }
  // ...
}

Additional context

---

What is the purpose of this pull request?

• Bug fix
• New Feature
• Documentation update
• Other

Before submitting the PR, please make sure you do the following

• Read the Contributing Guidelines.
• Read the Pull Request Guidelines and follow the Commit Convention.
• Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
• Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
• Ideally, include relevant tests that fail without this PR but pass with it.

[sapphi-red]

Would you add a test here?

vite/packages/vite/src/node/__tests__/utils.spec.ts

Line 13 in f328f61

describe('injectQuery', () => {

[yzydeveloper]

@sapphi-red f7c41be Test added

[sapphi-red]

Because we are not getting path part from the parsed URL, I guess we can remove this condition. refs #2435

Also this condition now doesn't make sense.
When resolvedUrl.protocol is file:, url has file: protocol. Then, we are passing file URL to pathToFileURL. This won't work.

/cc @poyoho

[yzydeveloper]

I agree that this condition should be removed.

[sapphi-red]

@yzydeveloper Would you remove this condition?

[yzydeveloper]

@sapphi-red This condition has been removed. 5a42330

[sapphi-red]

I confirmed this PR fixes #10278.

[sapphi-red]

Thank you!