fix: injectQuery double encoding
#18246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: mykwillis <myk@mykwillis.com>
sapphi-red
added
the
p3-minor-bug
|
|
sapphi-red
commented
Oct 1, 2024
Comment on lines
-316
to
-317
| // encode percents for consistent behavior with pathToFileURL | ||
| // see #2614 for details |
There was a problem hiding this comment.
This comment was irrelevant because pathToFileURL was removed in #10449.
| // encode percents for consistent behavior with pathToFileURL | ||
| // see #2614 for details | ||
| const resolvedUrl = new URL( | ||
| url.replace(replacePercentageRE, '%25'), |
There was a problem hiding this comment.
It works by simply removing this url.replace, but I think we can use splitFileAndPostfix and avoid new URL here.
|
/ecosystem-ci run |
|
📝 Ran ecosystem CI on
✅ astro, ladle, laravel, marko, nuxt, previewjs, quasar, qwik, rakkas, redwoodjs, storybook, sveltekit, unocss, vite-environment-examples, vite-plugin-pwa, vite-plugin-react, vite-plugin-react-swc, vite-plugin-svelte, vite-plugin-vue, vite-setup-catalogue, vitepress, vitest, vuepress |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
fixes #18244