Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: migrate to vitest #8076

Merged
merged 28 commits into from
May 11, 2022
Merged

test: migrate to vitest #8076

merged 28 commits into from
May 11, 2022

Conversation

antfu
Copy link
Member

@antfu antfu commented May 9, 2022 •
edited
Loading

Changes

  • Switch Jest to Vitest
  • Rewrote testUtils.js and all serve.js to ESM with TypeScript
  • Reworked setup files
  • Rewrite if (isBuild) usage to test.runIf(isBuild) and remove stub tests.

aladdin-add
aladdin-add reviewed May 10, 2022
View reviewed changes
CONTRIBUTING.md Outdated Show resolved Hide resolved
@benmccann benmccann mentioned this pull request May 10, 2022
Merged
9 tasks
@antfu antfu marked this pull request as ready for review May 11, 2022 01:17
@antfu
Copy link
Member Author

antfu commented May 11, 2022 •
edited
Loading

Damn, it's finally ready now! 🔥

@antfu antfu changed the title chore: migrate to vitest test: migrate to vitest May 11, 2022
patak-dev
patak-dev previously approved these changes May 11, 2022
View reviewed changes
Copy link
Member

@patak-dev patak-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing 🔥

benmccann
benmccann reviewed May 11, 2022
View reviewed changes
Copy link
Collaborator

@benmccann benmccann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome! really excited about this 😄

packages/vite/src/node/ssr/ssrModuleLoader.ts Show resolved Hide resolved
playground/vue-sourcemap/__tests__/serve.spec.ts Outdated Show resolved Hide resolved
@antfu antfu merged commit 8148f67 into main May 11, 2022
@antfu antfu deleted the chore/vitest branch May 11, 2022 06:33
@antfu
Copy link
Member Author

antfu commented May 11, 2022

Merged. Let me know if you encounter any issues with it. Cheers!

@sapphi-red sapphi-red mentioned this pull request May 13, 2022
Closed
9 tasks
@Geekhyt Geekhyt mentioned this pull request May 15, 2022
Open
@haoqunjiang haoqunjiang mentioned this pull request May 16, 2022
Closed
@patak-dev patak-dev mentioned this pull request May 20, 2022
Closed
4 tasks
@sxzz sxzz mentioned this pull request Jun 25, 2022
Closed
9 tasks
@sxzz sxzz mentioned this pull request Oct 6, 2023
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aladdin-add aladdin-add aladdin-add left review comments

@benmccann benmccann benmccann left review comments

@patak-dev patak-dev patak-dev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@antfu @benmccann @patak-dev @aladdin-add