VReplication: disable use of session_track_gtids (#16424)

Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
vitessio · Jul 17, 2024 · 7c30816 · 7c30816
1 parent c9c0aa5
commit 7c30816
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 16 deletions.
diff --git a/go/vt/vttablet/tabletserver/vstreamer/snapshot_conn.go b/go/vt/vttablet/tabletserver/vstreamer/snapshot_conn.go
@@ -88,14 +88,7 @@ func (conn *snapshotConn) streamWithSnapshot(ctx context.Context, table, query s
 			query, err)
 	}
 
-	_, err = conn.ExecuteFetch("set session session_track_gtids = START_GTID", 1, false)
-	if err != nil {
-		// session_track_gtids = START_GTID unsupported or cannot execute. Resort to LOCK-based snapshot
-		gtid, err = conn.startSnapshot(ctx, table)
-	} else {
-		// session_track_gtids = START_GTID supported. Get a transaction with consistent GTID without LOCKing tables.
-		gtid, err = conn.startSnapshotWithConsistentGTID(ctx)
-	}
+	gtid, err = conn.startSnapshot(ctx, table)
 	if err != nil {
 		return "", rotatedLog, err
 	}

diff --git a/go/vt/vttablet/tabletserver/vstreamer/tablestreamer.go b/go/vt/vttablet/tabletserver/vstreamer/tablestreamer.go
@@ -95,14 +95,7 @@ func (ts *tableStreamer) Stream() error {
 	defer conn.Close()
 	ts.snapshotConn = conn
 
-	_, err = conn.ExecuteFetch("set session session_track_gtids = START_GTID", 1, false)
-	if err != nil {
-		// session_track_gtids = START_GTID unsupported or cannot execute. Resort to LOCK-based snapshot
-		ts.gtid, err = conn.startSnapshotAllTables(ts.ctx)
-	} else {
-		// session_track_gtids = START_GTID supported. Get a transaction with consistent GTID without LOCKing tables.
-		ts.gtid, err = conn.startSnapshotWithConsistentGTID(ts.ctx)
-	}
+	ts.gtid, err = conn.startSnapshotAllTables(ts.ctx)
 	if err != nil {
 		return err
 	}