Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VReplication: disable use of session_track_gtids #16424

Merged
merged 1 commit into from
Jul 17, 2024

Conversation

shlomi-noach
Copy link
Contributor

Description

An alternative approach to #16421, addressing #16420.
It's really a completely different take: this PR disables the use of tracked session GTIDs, essentially undoing some of the work in #11061. VReplication table streamer and row streamer will only ever use the tried-and-true flush tables with read lock to capture a transactionally consistent GTID.

There are multiple reasons here. First, the discrepancy of behavior we have right now between different flavors of MySQL, and across different CI jobs. This makes debugging and reproducibility more difficult to handle, and we've struggled with this for a while.
Next, and what actually kicks this work, is we're seeing a bug, and incorrect value for the tracked GTID, under certain workloads and with specific table structures. We began investigation into this. Out of precaution, we prefer to disable it at this time.

Related Issue(s)

#16420

Checklist

  • "Backport to:" labels have been added if this change should be back-ported to release branches
  • If this change is to be back-ported to previous releases, a justification is included in the PR description
  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on CI?
  • Documentation was added or is not required

Deployment Notes

Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
Copy link
Contributor

vitess-bot bot commented Jul 17, 2024

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@vitess-bot vitess-bot bot added NeedsBackportReason If backport labels have been applied to a PR, a justification is required NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsWebsiteDocsUpdate What it says labels Jul 17, 2024
@shlomi-noach shlomi-noach changed the title VReplication: disable use of 'session_track_gtids' VReplication: disable use of session_track_gtids Jul 17, 2024
@github-actions github-actions bot added this to the v21.0.0 milestone Jul 17, 2024
@deepthi deepthi removed NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says NeedsIssue A linked issue is missing for this Pull Request NeedsBackportReason If backport labels have been applied to a PR, a justification is required labels Jul 17, 2024
Copy link
Member

@deepthi deepthi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine. I expect there might be some test failures which have to be fixed.

@shlomi-noach
Copy link
Contributor Author

We expect no test failures in this PR's CI jobs, as they all use vanilla MySQL, and so the behavior is effectively unchanged.

@shlomi-noach
Copy link
Contributor Author

OK, we choose to continue with this PR, over #16421 which I will now close.

Copy link

codecov bot commented Jul 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.66%. Comparing base (c9c0aa5) to head (8d42a01).

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #16424   +/-   ##
=======================================
  Coverage   68.66%   68.66%           
=======================================
  Files        1548     1548           
  Lines      199071   199063    -8     
=======================================
+ Hits       136683   136696   +13     
+ Misses      62388    62367   -21     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@shlomi-noach shlomi-noach merged commit 7c30816 into vitessio:main Jul 17, 2024
132 of 139 checks passed
@shlomi-noach shlomi-noach deleted the disable-tracked-gtids branch July 17, 2024 17:57
frouioui pushed a commit to frouioui/vitess that referenced this pull request Jul 19, 2024
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
dbussink added a commit to planetscale/vitess that referenced this pull request Nov 20, 2024
This was disabled in vitessio#16424, but we can clean up this additional code
since it's unused.

Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants