Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backup/restore: remove legacy binlog-server based PITR code #16673

Open
shlomi-noach opened this issue Aug 28, 2024 · 1 comment · May be fixed by #17361
Open

Backup/restore: remove legacy binlog-server based PITR code #16673

shlomi-noach opened this issue Aug 28, 2024 · 1 comment · May be fixed by #17361
Assignees
@shlomi-noach
Labels
Component: Backup and Restore Type: Internal Cleanup

Comments

@shlomi-noach
Copy link
Contributor

shlomi-noach commented Aug 28, 2024 •
edited
Loading

Years ago, a third party entity introduced point-in-time recovery based on mysql-ripple. That entity no longer uses said approach; the vitess team does not support it; in the years since we've not become aware of anyone else using it; mysql-ripple is archived.

We have termed this as "legacy" since v17: https://vitess.io/docs/archive/17.0/reference/features/recovery/

Vitess offers incremental backups and point in time recoveries based on binary logs and the standard mysqlbinlog binary.

We propose to completely remove the codebase that supports the binlog server approach.

Related:
@shlomi-noach shlomi-noach self-assigned this Aug 28, 2024
@shlomi-noach shlomi-noach mentioned this issue Dec 10, 2024
Merged
5 tasks
shlomi-noach added a commit to planetscale/vitess that referenced this issue Dec 10, 2024
@shlomi-noach
stop testing 'pitr', which tests a legacy binlog-server based PITR. See
abb23c4 
vitessio#16673

Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
dbussink pushed a commit to planetscale/vitess that referenced this issue Dec 10, 2024
@shlomi-noach @dbussink
stop testing 'pitr', which tests a legacy binlog-server based PITR. See
ef77118 
vitessio#16673

Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
@shlomi-noach shlomi-noach linked a pull request Dec 10, 2024 that will close this issue
Open
5 tasks
@shlomi-noach
Copy link
Contributor Author

Addressed by #17361

@shlomi-noach shlomi-noach mentioned this issue Dec 10, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shlomi-noach shlomi-noach

Labels
Component: Backup and Restore Type: Internal Cleanup
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove binlog-server point in time recoveries code & tests planetscale/vitess
1 participant
@shlomi-noach