-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove binlog-server point in time recoveries code & tests #17361
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #17361 +/- ##
==========================================
+ Coverage 67.46% 67.50% +0.04%
==========================================
Files 1581 1581
Lines 253934 253774 -160
==========================================
+ Hits 171305 171306 +1
+ Misses 82629 82468 -161 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
Should |
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
Good catch, removed. |
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
@@ -0,0 +1 @@ | |||
Do not remove. Ensures existence of directory. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Curious why we need the directory?
Description
This PR removes the legacy code for (Ripple) binlog-server based point in time recoveries. That code is unsupported since v17.
TBD:clarify in website docs that the feature is removed (right now it says "legacy", see https://vitess.io/docs/22.0/reference/features/recovery/#point-in-time-recovery-legacy-functionality-based-on-binlog-server)Docs: vitessio/website#1902. Just completely strip out the legacy docs.
Related Issue(s)
Closes #16673
Checklist
Deployment Notes