-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
delete unused flags and handling of deprecated protobuf fields #10612
Conversation
…fields Signed-off-by: deepthi <deepthi@planetscale.com>
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Bug fixes
Non-trivial changes
New/Existing features
Backward compatibility
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me! I wonder if 8 releases are enough to remove a deprecated flag 😆
|
Signed-off-by: Manan Gupta <manan@planetscale.com>
@deepthi I have pushed a fix for it. |
I will fix it. I wonder why more tests haven't failed with this error. |
Signed-off-by: deepthi <deepthi@planetscale.com>
… more deprecated fields Signed-off-by: deepthi <deepthi@planetscale.com>
…nd StreamExecute RPCs Signed-off-by: deepthi <deepthi@planetscale.com>
Signed-off-by: deepthi <deepthi@planetscale.com>
Signed-off-by: deepthi <deepthi@planetscale.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
java side changes looks good
Apparently, we are passing one of these flags in the vtop, so the end-to-end tests suddenly broke there and I traced it back here 🤣 . Anyways, I'll create a PR fixing this there. |
Commenting for completeness, the commit for fixing this on Vtop - planetscale/vitess-operator@a35f74b |
Description
Related Issue(s)
#5960
Checklist
Deployment Notes