Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

delete unused flags and handling of deprecated protobuf fields #10612

Merged
merged 7 commits into from
Jul 6, 2022

Conversation

deepthi
Copy link
Member

@deepthi deepthi commented Jun 29, 2022

Description

  • A number of deprecated flags from previous releases have been deleted
  • Special handling for deprecated protobuf fields has been deleted

Related Issue(s)

#5960

Checklist

  • "Backport me!" label has been added if this change should be backported
  • Tests were added or are not required
  • Documentation was added or is not required - release notes summary is included, website PR

Deployment Notes

…fields

Signed-off-by: deepthi <deepthi@planetscale.com>
@github-actions
Copy link
Contributor

github-actions bot commented Jun 29, 2022

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • If this is a change that users need to know about, please apply the release notes (needs details) label so that merging is blocked unless the summary release notes document is included.
  • If a new flag is being introduced, review whether it is really needed. The flag names should be clear and intuitive (as far as possible), and the flag's help should be descriptive.
  • If a workflow is added or modified, each items in Jobs should be named in order to mark it as required. If the workflow should be required, the GitHub Admin should be notified.

Bug fixes

  • There should be at least one unit or end-to-end test.
  • The Pull Request description should either include a link to an issue that describes the bug OR an actual description of the bug and how to reproduce, along with a description of the fix.

Non-trivial changes

  • There should be some code comments as to why things are implemented the way they are.

New/Existing features

  • Should be documented, either by modifying the existing documentation or creating new documentation.
  • New features should have a link to a feature request issue or an RFC that documents the use cases, corner cases and test cases.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • vtctl command output order should be stable and awk-able.

Copy link
Member

@GuptaManan100 GuptaManan100 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me! I wonder if 8 releases are enough to remove a deprecated flag 😆

@GuptaManan100
Copy link
Member

GuptaManan100 commented Jun 29, 2022

TestHelpOutput is failing the end-to-end test, because the output for vttablet --help has changed to not include the deprecated commands

Signed-off-by: Manan Gupta <manan@planetscale.com>
@GuptaManan100
Copy link
Member

@deepthi I have pushed a fix for it.

@deepthi
Copy link
Member Author

deepthi commented Jun 29, 2022

topo_connection_cache is a valid failure

2022-06-29T14:38:02.0006759Z I0629 14:27:10.354376   15288 vttablet_process.go:152] vttablet error:
2022-06-29T14:38:02.0007321Z flag provided but not defined: -enable-autocommit

I will fix it. I wonder why more tests haven't failed with this error.

Signed-off-by: deepthi <deepthi@planetscale.com>
proto/vtgate.proto Outdated Show resolved Hide resolved
deepthi added 4 commits June 30, 2022 13:09
… more deprecated fields

Signed-off-by: deepthi <deepthi@planetscale.com>
…nd StreamExecute RPCs

Signed-off-by: deepthi <deepthi@planetscale.com>
Signed-off-by: deepthi <deepthi@planetscale.com>
Signed-off-by: deepthi <deepthi@planetscale.com>
Copy link
Member

@harshit-gangal harshit-gangal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

java side changes looks good

@deepthi deepthi merged commit 2599788 into vitessio:main Jul 6, 2022
@deepthi deepthi deleted the ds-deprecations branch July 6, 2022 17:05
@GuptaManan100
Copy link
Member

Apparently, we are passing one of these flags in the vtop, so the end-to-end tests suddenly broke there and I traced it back here 🤣 . Anyways, I'll create a PR fixing this there.

@GuptaManan100
Copy link
Member

Commenting for completeness, the commit for fixing this on Vtop - planetscale/vitess-operator@a35f74b

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants