Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Task: cleanup deprecated flags and code #5960

Closed
Tracked by #11749
deepthi opened this issue Mar 24, 2020 · 2 comments · Fixed by #12083
Closed
Tracked by #11749

Task: cleanup deprecated flags and code #5960

deepthi opened this issue Mar 24, 2020 · 2 comments · Fixed by #12083

Comments

@deepthi
Copy link
Member

deepthi commented Mar 24, 2020

We need to review which of the following can be deleted in the current milestone.

~/go/src/vitess.io/vitess$ grep -n -i -r --include=\*.go deprecated --exclude=\*rice-box.go
go/vt/mysqlctl/mysql_daemon.go:63:	// Deprecated: use MasterPosition() instead
go/vt/mysqlctl/reparent.go:95:// Deprecated: use mysqld.MasterPosition() instead
go/vt/mysqlctl/fakemysqldaemon/fakemysqldaemon.go:336:// DemoteMaster is deprecated: use mysqld.MasterPosition() instead
go/vt/vtgate/vtgate.go:60:	_                  = flag.Bool("disable_local_gateway", false, "deprecated: if specified, this process will not route any queries to local tablets in the local cell")
go/vt/vtgate/executor.go:63:	// TODO: @rafael - These two counters should be deprecated in favor of the ByTable ones. They are kept for now for backwards compatibility.
go/vt/proto/topodata/topodata.pb.go:447:	// This field is in the process of being deprecated in favor of
go/vt/proto/vtgate/vtgate.pb.go:116:	// single_db is deprecated. Use transaction_mode instead.
go/vt/proto/vtgate/vtgate.pb.go:321:	// These values are deprecated. Use session instead.
go/vt/proto/vtgate/vtgate.pb.go:483:	// not_in_transaction is deprecated.
go/vt/proto/vtgate/vtgate.pb.go:651:	// not_in_transaction is deprecated.
go/vt/proto/vtgate/vtgate.pb.go:819:	// not_in_transaction is deprecated.
go/vt/proto/vtgate/vtgate.pb.go:989:	// not_in_transaction is deprecated.
go/vt/proto/vtgate/vtgate.pb.go:1214:	// These values are deprecated. Use session instead.
go/vt/proto/vtgate/vtgate.pb.go:1791:	// These values are deprecated. Use session instead.
go/vt/proto/vtgate/vtgate.pb.go:2312:	// single_db is deprecated. Use transaction_mode instead.
go/vt/proto/vtgate/vtgate.pb.go:2409:	// atomic is deprecated. Use transaction_mode instead.
go/vt/proto/vtrpc/vtrpc.pb.go:179:// LegacyErrorCode is the enum values for Errors. This type is deprecated.
go/vt/proto/vtrpc/vtrpc.pb.go:184:// In order to avoid confusion, this type will be deprecated in
go/vt/proto/binlogdata/binlogdata.pb.go:172:	// BL_DML is deprecated.
go/vt/proto/binlogdata/binlogdata.pb.go:173:	BinlogTransaction_Statement_BL_DML_DEPRECATED BinlogTransaction_Statement_Category = 4
go/vt/proto/binlogdata/binlogdata.pb.go:186:	4: "BL_DML_DEPRECATED",
go/vt/proto/binlogdata/binlogdata.pb.go:199:	"BL_DML_DEPRECATED": 4,
go/vt/proto/query/query.pb.go:3593:// - aggregate_stats is not set (deprecated)
go/vt/dbconfigs/dbconfigs.go:135:	flag.StringVar(&dbc.param.DeprecatedDBName, "db-config-"+userKey+"-dbname", "", "deprecated: dbname does not need to be explicitly configured")
go/vt/dbconfigs/dbconfigs.go:232:	if params.connParams.DeprecatedDBName != "" {
go/vt/dbconfigs/dbconfigs.go:233:		params.connParams.DbName = params.connParams.DeprecatedDBName
go/vt/topo/k8stopo/client/informers/externalversions/factory.go:86:// Deprecated: Please use NewSharedInformerFactoryWithOptions instead
go/vt/vttablet/tabletserver/tabletenv/config.go:45:	// Placeholder for deprecated variable.
go/vt/vttablet/tabletserver/tabletenv/config.go:47:	deprecatedMessagePoolPrefillParallelism int
go/vt/vttablet/tabletserver/tabletenv/config.go:48:	deprecatedAutocommit                    bool
go/vt/vttablet/tabletserver/tabletenv/config.go:58:	flag.IntVar(&deprecatedMessagePoolPrefillParallelism, "queryserver-config-message-conn-pool-prefill-parallelism", 0, "DEPRECATED: Unused.")
go/vt/vttablet/tabletserver/tabletenv/config.go:69:	flag.BoolVar(&deprecateAllowUnsafeDMLs, "queryserver-config-allowunsafe-dmls", false, "deprecated")
go/vt/vttablet/tabletserver/tabletenv/config.go:87:	flag.BoolVar(&deprecatedAutocommit, "enable-autocommit", true, "This flag is deprecated. Autocommit is always allowed.")
go/vt/worker/defaults.go:41:	// defaultDestinationPackCount is deprecated in favor of the writeQueryMax*
go/cmd/vtbackup/vtbackup.go:107:	_ = flag.Duration("timeout", 2*time.Hour, "DEPRECATED AND UNUSED")
go/cmd/vtbackup/vtbackup.go:108:	_ = flag.Duration("replication_timeout", 1*time.Hour, "DEPRECATED AND UNUSED")
go/sqltypes/value.go:158:// This function is deprecated. Use the type-specific
go/mysql/query.go:381:		// EOF is only present here if it's not deprecated.
go/mysql/query.go:416:			// The deprecated EOF packets change means that this is either an
go/mysql/replication_constants.go:24:	// TypeDecimal is MYSQL_TYPE_DECIMAL. It is deprecated.
go/mysql/conn_params.go:40:	// The following is only set when the deprecated "dbname" flags are
go/mysql/conn_params.go:42:	DeprecatedDBName string
go/mysql/streaming_query.go:75:		// EOF is only present here if it's not deprecated.
@deepthi
Copy link
Member Author

deepthi commented Mar 24, 2020

cc @morgo @sougou

@deepthi deepthi added this to the v7.0 milestone Jul 18, 2020
@deepthi deepthi modified the milestones: v7.0, v8.0 Jul 28, 2020
@deepthi
Copy link
Member Author

deepthi commented Jul 28, 2020

Some of the deprecated flags have been deleted. We'll re-evaluate the rest for 8.0.

@frouioui frouioui moved this to Backlog in v16.0.0 Nov 15, 2022
@frouioui frouioui removed this from the v16.0 milestone Nov 15, 2022
@deepthi deepthi assigned GuptaManan100 and unassigned deepthi Jan 10, 2023
@frouioui frouioui mentioned this issue Jan 11, 2023
35 tasks
@frouioui frouioui moved this from Backlog to In Progress in v16.0.0 Jan 12, 2023
@github-project-automation github-project-automation bot moved this from In Progress to Done in v16.0.0 Jan 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants