Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete deprecated flags #11360

Merged
merged 3 commits into from
Sep 27, 2022
Merged

Delete deprecated flags #11360

merged 3 commits into from
Sep 27, 2022

Conversation

deepthi
Copy link
Member

@deepthi deepthi commented Sep 26, 2022

Description

Deleted

  • planner_version
  • master_connect_retry

Related Issue(s)

#5960

Checklist

  • "Backport me!" label has been added if this change should be backported
  • Tests were added or are not required
  • Documentation was added or is not required

Deployment Notes

Documented in release notes summary.

@deepthi
flags: remove deprecated from test comment
a62e9f3 
Signed-off-by: deepthi <deepthi@planetscale.com>
@deepthi
flags: remove deprecated planner_version flag
45e14fe 
Signed-off-by: deepthi <deepthi@planetscale.com>
@deepthi
flags: remove deprecated master_connect_retry flag
37f49ed 
Signed-off-by: deepthi <deepthi@planetscale.com>
@vitess-bot
Copy link
Contributor

vitess-bot bot commented Sep 26, 2022 •
edited by ajm188
Loading

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • If this is a change that users need to know about, please apply the release notes (needs details) label so that merging is blocked unless the summary release notes document is included.
  • If a new flag is being introduced, review whether it is really needed. The flag names should be clear and intuitive (as far as possible), and the flag's help should be descriptive. Additionally, flag names should use dashes (-) as word separators rather than underscores (_).
  • If a workflow is added or modified, each items in Jobs should be named in order to mark it as required. If the workflow should be required, the GitHub Admin should be notified.

Bug fixes

  • There should be at least one unit or end-to-end test.
  • The Pull Request description should either include a link to an issue that describes the bug OR an actual description of the bug and how to reproduce, along with a description of the fix.

Non-trivial changes

  • There should be some code comments as to why things are implemented the way they are.

New/Existing features

  • Should be documented, either by modifying the existing documentation or creating new documentation.
  • New features should have a link to a feature request issue or an RFC that documents the use cases, corner cases and test cases.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • vtctl command output order should be stable and awk-able.

deepthi
deepthi commented Sep 26, 2022
View reviewed changes
go/flags/endtoend/vtctld.txt
@@ -86,7 +86,6 @@ Usage of vtctld:
--log_err_stacks log stack traces for errors
--log_rotate_max_size uint size in bytes at which logs are rotated (glog.MaxSize) (default 1887436800)
--logtostderr log to standard error instead of files
--master_connect_retry duration Deprecated, use -replication_connect_retry (default 10s)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have these flags on vtctld, vtctldclient etc. because we haven't migrated the mysqld package to pflag yet.

@deepthi deepthi merged commit 375d2d7 into vitessio:main Sep 27, 2022
@deepthi deepthi deleted the ds-deprecated-flags branch September 27, 2022 02:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajm188 ajm188 ajm188 approved these changes

@rohit-nayak-ps rohit-nayak-ps Awaiting requested review from rohit-nayak-ps rohit-nayak-ps is a code owner

@mattlord mattlord Awaiting requested review from mattlord mattlord is a code owner

@harshit-gangal harshit-gangal Awaiting requested review from harshit-gangal

Assignees
No one assigned
Labels
Component: Cluster management Component: Query Serving Type: Internal Cleanup
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@deepthi @ajm188