Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Deprecated flags, code and stats. #12083

Merged
merged 10 commits into from
Jan 20, 2023
Merged

Remove Deprecated flags, code and stats. #12083

merged 10 commits into from
Jan 20, 2023

Conversation

GuptaManan100
Copy link
Member

Description

This PR removed a lot of deprecated flags, code and stats which were deprecated in previous Vitess releases. The following changes have been made -

  1. Keyspace and TableName fields have been removed from LogStats.
  2. QueriesProcessed, QueriesRoutedStats and QueryRowCounts have been removed.
  3. enable_semi_sync flag has been removed.
  4. DeprecatedDBName field which wasn't been written to is also removed.

Related Issue(s)

Checklist

  • "Backport to:" labels have been added if this change should be back-ported
  • Tests were added or are not required
  • Documentation was added or is not required

Deployment Notes

@GuptaManan100
feat: remove deprecated fields in logstats
aa03853 
Signed-off-by: Manan Gupta <manan@planetscale.com>
@GuptaManan100 GuptaManan100 added Type: Internal Cleanup Component: General Changes throughout the code base labels Jan 12, 2023
@vitess-bot vitess-bot bot added NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says labels Jan 12, 2023
@vitess-bot
Copy link
Contributor

vitess-bot bot commented Jan 12, 2023 •
edited by frouioui
Loading

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • If this is a change that users need to know about, please apply the release notes (needs details) label so that merging is blocked unless the summary release notes document is included.
  • If a test is added or modified, there should be a documentation on top of the test to explain what the expected behavior is what the test does.

If a new flag is being introduced:

  • Is it really necessary to add this flag?
  • Flag names should be clear and intuitive (as far as possible)
  • Help text should be descriptive.
  • Flag names should use dashes (-) as word separators rather than underscores (_).

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow should be required, the maintainer team should be notified.

Bug fixes

  • There should be at least one unit or end-to-end test.
  • The Pull Request description should include a link to an issue that describes the bug.

Non-trivial changes

  • There should be some code comments as to why things are implemented the way they are.

New/Existing features

  • Should be documented, either by modifying the existing documentation or creating new documentation.
  • New features should have a link to a feature request issue or an RFC that documents the use cases, corner cases and test cases.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • vtctl command output order should be stable and awk-able.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from VTop, if used there.

@GuptaManan100 GuptaManan100 removed NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says labels Jan 12, 2023
@GuptaManan100 GuptaManan100 requested a review from ajm188 as a code owner January 12, 2023 11:41
frouioui
frouioui reviewed Jan 12, 2023
View reviewed changes
go/vt/vttablet/tabletmanager/rpc_replication.go
Comment on lines -45 to -46
fs.Bool("enable_semi_sync", false, "")
fs.MarkDeprecated("enable_semi_sync", "please set the correct durability policy on the keyspace instead.")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should remove this flag's usage in our end-to-end tests as well. The field EnableSemiSync can be removed from LocalProcessCluster.

I think this would unblock three of the failing CI workflows.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just realized that removing flags on main can break upgrade/downgrade tests on v15 - because we test with N+1. We may need to go back and check how this affects those tests on release-15.0 branch.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have remove EnableSemiSync from the vttablet process and the local process cluster. Also @deepthi is right, I'll have to fix upgrade-downgrade tests in v15 too. I'll do that in a separate PR.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good

frouioui
frouioui approved these changes Jan 17, 2023
View reviewed changes
Copy link
Member

@frouioui frouioui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Let's remember to create a PR on release-15.0 to fix the upgrade/downgrade tests

deepthi
deepthi reviewed Jan 17, 2023
View reviewed changes
go/vt/vtgate/executor.go Outdated Show resolved Hide resolved
@GuptaManan100
feat: remove enable_semi_sync
2c3d08c 
Signed-off-by: Manan Gupta <manan@planetscale.com>
@GuptaManan100
feat: remove QueryRowCounts stat
ff9dd89 
Signed-off-by: Manan Gupta <manan@planetscale.com>
@GuptaManan100
feat: remove deprecated and unused field
50e7b1f 
Signed-off-by: Manan Gupta <manan@planetscale.com>
@GuptaManan100
feat: remove unused code
b1745a0 
Signed-off-by: Manan Gupta <manan@planetscale.com>
@GuptaManan100
release-notes: fix review comments in release-notes
6464d99 
Signed-off-by: Manan Gupta <manan@planetscale.com>
@GuptaManan100
test: remove enable_semi_sync flag from the tests
8a2e815 
Signed-off-by: Manan Gupta <manan@planetscale.com>
@GuptaManan100
feat: remove tests for QueryRowCounts
30ba7d4 
Signed-off-by: Manan Gupta <manan@planetscale.com>
@GuptaManan100
feat: deprecate QueriesProcessed and QueriesRouted
292507f 
Signed-off-by: Manan Gupta <manan@planetscale.com>
@GuptaManan100 GuptaManan100 requested a review from deepthi January 18, 2023 14:20
deepthi
deepthi approved these changes Jan 20, 2023
View reviewed changes
Copy link
Member

@deepthi deepthi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One more comment, rest LGTM.

doc/releasenotes/16_0_0_summary.md Outdated Show resolved Hide resolved
@GuptaManan100
docs: make versions consistant in the release summary
fbe1310 
Signed-off-by: Manan Gupta <manan@planetscale.com>
@GuptaManan100 GuptaManan100 merged commit 2d6c719 into vitessio:main Jan 20, 2023
@GuptaManan100 GuptaManan100 deleted the remove-deprecated branch January 20, 2023 08:45
@GuptaManan100
Copy link
Member Author

There are changes required after this on release-15.0 and also on the vitess-operator. I am working on those now.

@GuptaManan100 GuptaManan100 mentioned this pull request Jan 20, 2023
Merged
3 tasks
@GuptaManan100
Copy link
Member Author

This PR fixes release-15.0 too, so that upgrade-downgrade tests start working again - #12128

@GuptaManan100 GuptaManan100 mentioned this pull request Jan 23, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frouioui frouioui frouioui approved these changes

@deepthi deepthi deepthi approved these changes

@harshit-gangal harshit-gangal Awaiting requested review from harshit-gangal harshit-gangal is a code owner

@systay systay Awaiting requested review from systay systay is a code owner

@shlomi-noach shlomi-noach Awaiting requested review from shlomi-noach shlomi-noach is a code owner

@rohit-nayak-ps rohit-nayak-ps Awaiting requested review from rohit-nayak-ps rohit-nayak-ps is a code owner

@rsajwani rsajwani Awaiting requested review from rsajwani

@mattlord mattlord Awaiting requested review from mattlord mattlord is a code owner

@ajm188 ajm188 Awaiting requested review from ajm188 ajm188 is a code owner

@derekperkins derekperkins Awaiting requested review from derekperkins derekperkins is a code owner

@dkhenry dkhenry Awaiting requested review from dkhenry

Assignees
No one assigned
Labels
Component: General Changes throughout the code base Type: Internal Cleanup
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Task: cleanup deprecated flags and code
3 participants
@GuptaManan100 @deepthi @frouioui