Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-20.0] planner: Handle ORDER BY inside derived tables (#16353) #16360

Merged
merged 3 commits into from
Jul 10, 2024

restrict test to v20

c236886
Select commit
Loading
Failed to load commit list.
Merged

[release-20.0] planner: Handle ORDER BY inside derived tables (#16353) #16360

restrict test to v20
c236886
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jul 10, 2024 in 0s

68.67% (+0.01%) compared to 795a7e5

View this Pull Request on Codecov

68.67% (+0.01%) compared to 795a7e5

Details

Codecov Report

Attention: Patch coverage is 88.88889% with 5 lines in your changes missing coverage. Please review.

Project coverage is 68.67%. Comparing base (795a7e5) to head (c236886).

Files Patch % Lines
go/vt/vtgate/planbuilder/operators/route.go 86.66% 4 Missing ⚠️
...vt/vtgate/planbuilder/operators/queryprojection.go 90.90% 1 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff                @@
##           release-20.0   #16360      +/-   ##
================================================
+ Coverage         68.66%   68.67%   +0.01%     
================================================
  Files              1541     1541              
  Lines            197830   197827       -3     
================================================
+ Hits             135833   135855      +22     
+ Misses            61997    61972      -25     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.