-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Vreplication: control streamer snapshot method via rule/filter directives #16421
Vreplication: control streamer snapshot method via rule/filter directives #16421
Conversation
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #16421 +/- ##
==========================================
- Coverage 68.69% 68.67% -0.03%
==========================================
Files 1548 1548
Lines 199090 199097 +7
==========================================
- Hits 136766 136721 -45
- Misses 62324 62376 +52 ☔ View full report in Codecov by Sentry. |
Closing for now in favor of #16424. We can revisit in the future. |
Description
Implements a solution to #16420:
StreamerSnapshotMethod
and associated field in proto/Rule
ukForce
orukColumns
.Right now this is just offered as a potential functionality, and the actual behavior is unchanged. In the future, we may choose to actually make educated choices to pick the preferred snapshot method.
This change is internal facing and not to be documented yet.
Related Issue(s)
Fixes #16420
Checklist
Deployment Notes