-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove unused code for old START_GTID logic #17265
Merged
dbussink
merged 1 commit into
vitessio:main
from
planetscale:dbussink/cleanup-unused-start-gtid-code
Nov 20, 2024
Merged
Remove unused code for old START_GTID logic #17265
dbussink
merged 1 commit into
vitessio:main
from
planetscale:dbussink/cleanup-unused-start-gtid-code
Nov 20, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was disabled in vitessio#16424, but we can clean up this additional code since it's unused. Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com>
dbussink
requested review from
harshit-gangal,
systay,
shlomi-noach,
rohit-nayak-ps and
timvaillancourt
as code owners
November 20, 2024 14:11
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
vitess-bot
bot
added
NeedsBackportReason
If backport labels have been applied to a PR, a justification is required
NeedsDescriptionUpdate
The description is not clear or comprehensive enough, and needs work
NeedsIssue
A linked issue is missing for this Pull Request
NeedsWebsiteDocsUpdate
What it says
labels
Nov 20, 2024
dbussink
removed
NeedsDescriptionUpdate
The description is not clear or comprehensive enough, and needs work
NeedsWebsiteDocsUpdate
What it says
NeedsIssue
A linked issue is missing for this Pull Request
NeedsBackportReason
If backport labels have been applied to a PR, a justification is required
labels
Nov 20, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #17265 +/- ##
=======================================
Coverage 67.37% 67.38%
=======================================
Files 1573 1573
Lines 253110 253085 -25
=======================================
- Hits 170535 170531 -4
+ Misses 82575 82554 -21 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
shlomi-noach
approved these changes
Nov 20, 2024
arthurschreiber
approved these changes
Nov 20, 2024
rvrangel
pushed a commit
to rvrangel/vitess
that referenced
this pull request
Nov 21, 2024
Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com> Signed-off-by: Renan Rangel <rrangel@slack-corp.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was disabled in #16424, but we can clean up this additional code since it's unused.
Related Issue(s)
Follow up to #16424
Checklist