Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The test is broken due to
EXTRA_BIN
directory non-existing. We ttempt to download thevault
binary onto that directory, which of course fails:vitess/go/test/endtoend/vault/vault_server.go
Lines 61 to 65 in e4dc872
Initial commit: no fix; reproduce.
Related Issue(s)
This bug was there for a while. Exposed by #17354.
Checklist
Deployment Notes