Travis: Enable retries for unit tests as well. #921
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
At this point, they are too flaky and it hinders productivity too much to bother with that.
|
LGTM |
michael-berlin
added a commit
that referenced
this pull request
Jul 24, 2015
Travis: Enable retries for unit tests as well.
systay
pushed a commit
to planetscale/vitess
that referenced
this pull request
Aug 19, 2022
The refactor of the Watch implementation led me to accidentally adding this to the watcher, but we should keep the same implementation and not add those close here. Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com>
notfelineit
pushed a commit
to planetscale/vitess
that referenced
this pull request
Sep 21, 2022
* Revert "Add explicit close state to memory topo connection (vitessio#11110) (vitessio#1016)" This reverts commit eb1e9c2. * Revert "Fix races in memory topo and watcher (vitessio#11065) (vitessio#995)" This reverts commit 6bc0171. * Revert "Avoid race condition in watch shutdown (vitessio#10954) (vitessio#936)" This reverts commit 23d4e34. * Revert "Remove potential double close of channel (vitessio#10929) (vitessio#921)" This reverts commit 0121e5d. * Revert "Cherry pick topo improvements (vitessio#10906) (vitessio#916)" This reverts commit 8c9f56d.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At this point, they are too flaky and it hinders productivity too much to bother with that.
@alainjobart