Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor java client pom structure #936

Merged
merged 1 commit into from
Jul 29, 2015
Merged

refactor java client pom structure #936

merged 1 commit into from
Jul 29, 2015

Conversation

yaoshengzhe
Copy link
Contributor

  1. move common dependencies into parent pom.
  2. upgrade com.google.guava to 18.0.

@alainjobart
Copy link
Contributor

LGTM

@yaoshengzhe
refactor java client pom structure
982e1e2 
1. move common dependencies into parent pom.
2. upgrade com.google.guava to 18.0.
3. rename java build target to java_client_test.
4. fix makefile so java client test will run tests from each sub package.
@yaoshengzhe
Copy link
Contributor Author

also disable gorpc tests since it is flaky in travis environment and will be deprecated soon.

@alainjobart
Copy link
Contributor

LGTM

yaoshengzhe added a commit that referenced this pull request Jul 29, 2015
@yaoshengzhe
Merge pull request #936 from yaoshengzhe/fix_refactor_java_pom_structure
81a05f7 
refactor java client pom structure
@yaoshengzhe yaoshengzhe merged commit 81a05f7 into vitessio:master Jul 29, 2015
@yaoshengzhe yaoshengzhe deleted the fix_refactor_java_pom_structure branch July 30, 2015 16:55
systay pushed a commit to planetscale/vitess that referenced this pull request Aug 19, 2022
@dbussink
Avoid race condition in watch shutdown (vitessio#10954) (vitessio#936)
23d4e34 
When we call close we want to lock around clearing out the factory
object. In the watch goroutine shutdown we want to grab a reference to
the factory to ensure that it can keep going with the shutdown
procedure.

It's still possible to panic here on wrong usage but that's deliberate
to avoid reuse of the memory topo.

Found with the race detector on a build:

```
==================
WARNING: DATA RACE
Write at 0x00c00047c780 by goroutine 19:
  vitess.io/vitess/go/vt/topo/memorytopo.(*Conn).Close()
      /home/runner/work/vitess-private/vitess-private/go/vt/topo/memorytopo/memorytopo.go:145 +0x30
  vitess.io/vitess/go/vt/topo.(*StatsConn).Close()
      /home/runner/work/vitess-private/vitess-private/go/vt/topo/stats_conn.go:201 +0x17e
  vitess.io/vitess/go/vt/topo.(*Server).Close()
      /home/runner/work/vitess-private/vitess-private/go/vt/topo/server.go:335 +0x25a
  vitess.io/vitess/go/vt/topo/test.TopoServerTestSuite()
      /home/runner/work/vitess-private/vitess-private/go/vt/topo/test/testing.go:125 +0x605
  vitess.io/vitess/go/vt/topo/memorytopo.TestMemoryTopo()
      /home/runner/work/vitess-private/vitess-private/go/vt/topo/memorytopo/server_test.go:28 +0x35
  testing.tRunner()
      /opt/hostedtoolcache/go/1.18.4/x64/src/testing/testing.go:1439 +0x213
  testing.(*T).Run.func1()
      /opt/hostedtoolcache/go/1.18.4/x64/src/testing/testing.go:1486 +0x47

Previous read at 0x00c00047c780 by goroutine 32:
  vitess.io/vitess/go/vt/topo/memorytopo.(*Conn).Watch.func1()
      /home/runner/work/vitess-private/vitess-private/go/vt/topo/memorytopo/watch.go:58 +0xbc

Goroutine 19 (running) created at:
  testing.(*T).Run()
      /opt/hostedtoolcache/go/1.18.4/x64/src/testing/testing.go:1486 +0x724
  testing.runTests.func1()
      /opt/hostedtoolcache/go/1.18.4/x64/src/testing/testing.go:1839 +0x99
  testing.tRunner()
      /opt/hostedtoolcache/go/1.18.4/x64/src/testing/testing.go:1439 +0x213
  testing.runTests()
      /opt/hostedtoolcache/go/1.18.4/x64/src/testing/testing.go:1837 +0x7e4
  testing.(*M).Run()
      /opt/hostedtoolcache/go/1.18.4/x64/src/testing/testing.go:1719 +0xa71
  main.main()
      _testmain.go:47 +0x2e4

Goroutine 32 (finished) created at:
  vitess.io/vitess/go/vt/topo/memorytopo.(*Conn).Watch()
      /home/runner/work/vitess-private/vitess-private/go/vt/topo/memorytopo/watch.go:53 +0x564
  vitess.io/vitess/go/vt/topo.(*StatsConn).Watch()
      /home/runner/work/vitess-private/vitess-private/go/vt/topo/stats_conn.go:168 +0x201
  vitess.io/vitess/go/vt/topo/test.waitForInitialValue()
      /home/runner/work/vitess-private/vitess-private/go/vt/topo/test/watch.go:42 +0xdb
  vitess.io/vitess/go/vt/topo/test.checkWatch()
      /home/runner/work/vitess-private/vitess-private/go/vt/topo/test/watch.go:140 +0x414
  vitess.io/vitess/go/vt/topo/test.TopoServerTestSuite()
      /home/runner/work/vitess-private/vitess-private/go/vt/topo/test/testing.go:116 +0x564
  vitess.io/vitess/go/vt/topo/memorytopo.TestMemoryTopo()
      /home/runner/work/vitess-private/vitess-private/go/vt/topo/memorytopo/server_test.go:28 +0x35
  testing.tRunner()
      /opt/hostedtoolcache/go/1.18.4/x64/src/testing/testing.go:1439 +0x213
  testing.(*T).Run.func1()
      /opt/hostedtoolcache/go/1.18.4/x64/src/testing/testing.go:1486 +0x47
==================

Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com>
--- FAIL: TestMemoryTopo (0.06s)
    testing.go:49: === checkKeyspace
    testing.go:54: === checkShard
    testing.go:59: === checkTablet
    testing.go:64: === checkShardReplication
    testing.go:69: === checkSrvKeyspace
    testing.go:74: === checkSrvVSchema
    testing.go:79: === checkLock
    lock.go:49: ===      checkLockTimeout
    lock.go:52: ===      checkLockMissing
    lock.go:55: ===      checkLockUnblocks
    testing.go:84: === checkVSchema
    testing.go:89: === checkRoutingRules
    testing.go:94: === checkElection
    testing.go:99: === checkWaitForNewLeader
    testing.go:104: === checkDirectory
    directory.go:33: ===   checkDirectoryInCell global
    directory.go:41: ===   checkDirectoryInCell test
    testing.go:109: === checkFile
    file.go:33: ===   checkFileInCell global
    file.go:41: ===   checkFileInCell global
    testing.go:114: === checkWatch
    testing.go:119: === checkList
    testing.go:122: === checkWatchRecursive
    testing.go:1312: race detected during execution of test
FAIL
FAIL	vitess.io/vitess/go/vt/topo/memorytopo	0.087s
```

Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com>
notfelineit pushed a commit to planetscale/vitess that referenced this pull request Sep 21, 2022
@mattlord
Revert WatchRecursive Topo Feature (vitessio#1023)
ba735af 
* Revert "Add explicit close state to memory topo connection (vitessio#11110) (vitessio#1016)"

This reverts commit eb1e9c2.

* Revert "Fix races in memory topo and watcher (vitessio#11065) (vitessio#995)"

This reverts commit 6bc0171.

* Revert "Avoid race condition in watch shutdown (vitessio#10954) (vitessio#936)"

This reverts commit 23d4e34.

* Revert "Remove potential double close of channel (vitessio#10929) (vitessio#921)"

This reverts commit 0121e5d.

* Revert "Cherry pick topo improvements (vitessio#10906) (vitessio#916)"

This reverts commit 8c9f56d.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yaoshengzhe @alainjobart