Extend NIP93 Profile Gallery with Nip68 Events #1210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
it keeps the nip93 gallery as before, but also adds all nip68 media to the gallery
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an alternative PR to #1208
It keeps the user gallery as before (including kind 1163 events) but it also adds NIP68 Kind 20 events. These will be added when posting via the multimedia tab, or on other clients like Olas.
This way users with already large galleries, keep their entries. Users might opt to use the multimedia feed in the future.
(Add to media gallery on images is still there but could be deprecated in the future in favor of kind 20)
Additionally, same as in the other PR: