-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tools.vpm: add installs from git version tags #19813
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ttytm
changed the title
wip: version install; add parse_query() []Module; decouple
tools.vpm: add installs from git version tags
Nov 9, 2023
ttytm
force-pushed
the
vpm/version-install
branch
3 times, most recently
from
November 9, 2023 02:32
2a8f095
to
87aba71
Compare
make minor refinements to update cleanup
add error details about why version install failed make `confirm_install` part of `install` to reduce redundancy add `Installed` print on install success
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The change updates and extends VPM to install module versions based on git tags.
E.g. when installing modules
And when specifying dependencies in a v.mod file
In its current state, the VPM module lacked the foundation for such feature. The PR therefore makes some fundamental updates that also come with additional fixes and performance improvements. The recently added tests and updates can certainly make it easier to wave through a big change like this, but this PR is still a chunk thrown at you as a reviewer.
I suggest it this way because going small steps on the current code would be extremely time-consuming for me as a programmer - to keep things working at every step while trying to make fundamental changes -, it would lead to a flood of PRs and would - bottom line - probably also take up more of your time. So please bare with me.
A short overview of what comes with the changes in this PR.
[]Module
arrays that store all data that is needed instead of working with[]string
arrays for the whole process. This allows to remove some highly coupled parts of code and to reduce redundancy where the same module data was requested from different functions at different stages.I still carry a long list of things how vpm can be further improved to achieve a high-quality and tailored product. But none that would require an extensive change like this one, and I would like to continue working on them separately after proposed changes have been resolved.
On further changes that are not as extensive in terms of code changes for the VPM module but also fundamental: I think we should require a
v.mod
file for vpm installations. Just as aCargo.toml
is required for rust cargo and ago.mod
for go modules. At current master it's possible to fetch any git repo withv install <url>
.