vpm: add parse_query #19814
vpm: add parse_query #19814
Conversation
| fn get_mod_date_info(mut pp pool.PoolProcessor, idx int, wid int) &ModDateInfo { | ||
| mut result := &ModDateInfo{ | ||
| fn parse_query(query []string) ([]Module, []Module) { | ||
| mut vpm_modules, mut extended_modules := []Module{}, []Module{} |
There was a problem hiding this comment.
| mut vpm_modules, mut extended_modules := []Module{}, []Module{} | |
| mut vpm_modules, mut external_modules := []Module{}, []Module{} |
There was a problem hiding this comment.
Good catch, ty. https would be even shorter. But the install method can be extended to also support other instal methods. So external would cover this as well.
There was a problem hiding this comment.
it can be changed in a future PR to avoid triggering the CI just for that
| @@ -28,25 +29,22 @@ fn vpm_install(requested_modules []string) { | |||
| exit(2) | |||
| } | |||
| } else { | |||
| requested_modules.clone() | |||
There was a problem hiding this comment.
I think that this return input_param.clone() here, was deliberate, to avoid a problem with V itself, when vpm_install was called with []string on the stack, and then the result was passed towards a higher level caller. I am not sure if that is fixed already, it may be 🤔 , just something to keep in mind.
There was a problem hiding this comment.
Afaik the clone was needed as we did a direct assignment. Now we pass it to the function that returns two new arrays.
Based on the end result of #19813 we can make it a 3 or 4 part change which can be better monitored.
This PRs main change: