Skip to content
This repository has been archived by the owner on Dec 15, 2021. It is now read-only.

<cmd/function>: make user be able to choose image-pull-policy #741

Merged
merged 1 commit into from
May 9, 2018
Merged

<cmd/function>: make user be able to choose image-pull-policy #741

merged 1 commit into from
May 9, 2018

Conversation

knightXun
Copy link
Contributor

I notice image-poll-policy of the pod created by kubeless is always.we should let user choose their image-pull-policy, Including (IfNotPresent,Never,Always).

@andresmgot
Copy link
Contributor

Hi @knightXun, could you explain the use case of this change? We want to avoid having a really big set of flags for deployments. Note that users can still specify a custom deployment if they want to configure something very specific: https://kubeless.io/docs/advanced-function-deployment/#custom-deployment

@knightXun
Copy link
Contributor Author

@andresmgot ok
Sometimes, user may want to pull newest images from dockerhub.If the images located in dockerhub, It will run successfully.
But if the images is not present on dockerhub,but existed in local machine, we should let the pod created by kubeless function use this image, not pull from dockerhub.
I made a little change to offer user this option.

@knightXun
Copy link
Contributor Author

Cause kubeless function deploy/update make users choose their runtime-images, We better to offer image-pull-policy.

@andresmgot
Copy link
Contributor

Fair enough! Thanks for the pull request!

@andresmgot andresmgot merged commit e2e9bcf into vmware-archive:master May 9, 2018
@knightXun knightXun deleted the image-pull branch May 10, 2018 01:27
andresmgot pushed a commit that referenced this pull request May 16, 2018
* Added --from-url command line flag

* modified method name to getHTTPSha256

* modified method name to getHTTPSha256 in function call

* change some terms in architecture.md (#728)

* modified PR 726 to use curl to retrieve function code in getProvisionContainer

* code formatting changes to pass build

* fix cmd/kubeless/autoscale some typo (#729)

* pv for kafka (#735)

* pv for kafka

* Update README.md

Fix some typos and links

* Point to latest release in quick-start guide

* <script/binary>: print more information when building (#739)

* <script/binary>: print more information when building

* Update binary

Fix typo

* <cmd/function>: make user be able to choose image-pull-policy (#741)

* <cmd/kubeless/logs>: change some typo and judge all containers in pod (#742)

* Add response object to function event (#745)

* Add response object to function event

* Add docs

* CircleCI integration (#743)

* CircleCI integration

* Fix builder image ref

* Remove debug code

* Minor review

* Store artifacts

* Add ca-certificates to Golang runtime image (#749)

* modified --from-file and --dependencies to support URLs

* Added --from-url command line flag

* modified method name to getHTTPSha256

* modified method name to getHTTPSha256 in function call

* modified PR 726 to use curl to retrieve function code in getProvisionContainer

* code formatting changes to pass build

* modified --from-file and --dependencies to support URLs

* created parseContent function
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants