This repository has been archived by the owner on Dec 15, 2021. It is now read-only.
Add response object to function event #745
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
May 10, 2018 16:26
|
LGTM |
andresmgot
pushed a commit
that referenced
this pull request
May 16, 2018
* Added --from-url command line flag * modified method name to getHTTPSha256 * modified method name to getHTTPSha256 in function call * change some terms in architecture.md (#728) * modified PR 726 to use curl to retrieve function code in getProvisionContainer * code formatting changes to pass build * fix cmd/kubeless/autoscale some typo (#729) * pv for kafka (#735) * pv for kafka * Update README.md Fix some typos and links * Point to latest release in quick-start guide * <script/binary>: print more information when building (#739) * <script/binary>: print more information when building * Update binary Fix typo * <cmd/function>: make user be able to choose image-pull-policy (#741) * <cmd/kubeless/logs>: change some typo and judge all containers in pod (#742) * Add response object to function event (#745) * Add response object to function event * Add docs * CircleCI integration (#743) * CircleCI integration * Fix builder image ref * Remove debug code * Minor review * Store artifacts * Add ca-certificates to Golang runtime image (#749) * modified --from-file and --dependencies to support URLs * Added --from-url command line flag * modified method name to getHTTPSha256 * modified method name to getHTTPSha256 in function call * modified PR 726 to use curl to retrieve function code in getProvisionContainer * code formatting changes to pass build * modified --from-file and --dependencies to support URLs * created parseContent function
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Ref: Fixes #712
Description:
Add response object to
event.extensions. It allows function to customize response properties like the status code or headers.It is not necessary to perform any change for Python and Ruby since it is already possible to return a
responseobject for those frameworks.TODOs: