Set default tunnel type to geneve #903
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your PR. The following commands are available:
These commands can only be run by members of the vmware-tanzu organization. |
antoninbas
force-pushed
the
set-default-tunnel-type-to-geneve
branch
from
2c3881f to
d423421
Compare
jianjuns
reviewed
Jul 2, 2020
ci/kind/test-e2e-kind.sh
Outdated
| manifest_args="" | ||
| if $proxy; then | ||
| # See https://github.com/vmware-tanzu/antrea/issues/897 | ||
| manifest_args="$manifest_args --proxy --tun vxlan" |
There was a problem hiding this comment.
These should be for np, not proxy?
antoninbas
force-pushed
the
set-default-tunnel-type-to-geneve
branch
2 times, most recently
from
5150e60 to
975ed2e
Compare
jianjuns
previously approved these changes
Jul 2, 2020
abhiraut
previously approved these changes
Jul 2, 2020
|
/test-all |
antoninbas
force-pushed
the
set-default-tunnel-type-to-geneve
branch
2 times, most recently
from
3ce3de7 to
f9c9db2
Compare
|
/test-all |
antoninbas
force-pushed
the
set-default-tunnel-type-to-geneve
branch
from
f9c9db2 to
5f3f709
Compare
|
/test-all |
antoninbas
force-pushed
the
set-default-tunnel-type-to-geneve
branch
from
5f3f709 to
7dc1674
Compare
antoninbas
force-pushed
the
set-default-tunnel-type-to-geneve
branch
from
7dc1674 to
d2ce384
Compare
|
/test-all |
|
/test-windows-conformance |
1 similar comment
|
/test-windows-conformance |
When running NetworkPolicy tests in Kind, we "force" the tunnel type to VXLAN as we observe some failures with Geneve (see antrea-io#897). We also change the Github CI jobs so that CNP tests are run in their own job. This is to address the issue above, and is also a partial implementation of antrea-io#893.
antoninbas
force-pushed
the
set-default-tunnel-type-to-geneve
branch
from
d2ce384 to
e488a9e
Compare
The patch for security CRDs was incorrect. It seems the behavior for patching ClusterRole rules is "replace" and not "merge".
|
/test-all |
jianjuns
approved these changes
Jul 3, 2020
abhiraut
approved these changes
Jul 3, 2020
|
Traceflow test failed in jenkins-e2e but it seems unrelated (#906 (comment)), so merging as is |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set default tunnel type to Geneve
Set default tunnel type to Geneve for Antrea instead of VXLAN.
When running NetworkPolicy tests in Kind, we "force" the tunnel type to
VXLAN as we observe some failures with Geneve (see #897).
We also change the Github CI jobs so that CNP tests are run in their own
job. This is to address the issue above, and is also a partial
implementation of #893.