Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove linter from concourse #136

Merged
merged 2 commits into from
Jan 12, 2022

Conversation

migmartri
Copy link
Contributor

We are currently running the golangci-lint twice, once in the github action and also in the concourse pipeline.

In my opinion the execution in the internal pipeline should be remove because of

  • We are moving away from the use of a monolithic internal pipeline step in favor of public facing single purpose Github actions
  • By running it in two places, by two different systems we can run into inconsistencies, for example, the golangci github action is configured in a specific way that concourse doesn't know about.

Signed-off-by: Miguel Martinez Trivino mtrivino@vmware.com

@migmartri migmartri requested review from josvazg and petewall January 12, 2022 14:16
Miguel Martinez Trivino added 2 commits January 12, 2022 16:38
Signed-off-by: Miguel Martinez Trivino <mtrivino@vmware.com>
Signed-off-by: Miguel Martinez Trivino <mtrivino@vmware.com>
Copy link
Contributor

@petewall petewall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@migmartri migmartri merged commit 8896985 into vmware-tanzu:main Jan 12, 2022
@migmartri migmartri deleted the remove-linter branch January 12, 2022 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants