Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove linter from concourse #136

Merged
merged 2 commits into from
Jan 12, 2022
Merged

chore: remove linter from concourse #136

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0d9a5d1
chore: remove linter from concourse
Jan 12, 2022
ba392ea
remove linter from pr as well
Jan 12, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions ci/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,9 +8,6 @@ WORKDIR /
RUN yum -y install build-essential coreutils gawk gcc git go-1.17.2-1.ph3.x86_64 jq make
ENV PATH="/root/go/bin:${PATH}"

ARG GOLANGCI_LINT_VERSION="v1.42.0"
RUN curl -sSfL https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh | sh -s -- -b $(go env GOPATH)/bin ${GOLANGCI_LINT_VERSION}

# Install go packages used for building and testing
RUN go get -u github.com/maxbrunsfeld/counterfeiter/v6 \
github.com/onsi/ginkgo/ginkgo \
Expand Down
10 changes: 0 additions & 10 deletions ci/pipeline.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,11 +99,6 @@ jobs:
trigger: true
- get: source
trigger: true
- task: run-lint
image: test-image
file: source/ci/tasks/test.yaml
params:
MAKE_TARGET: lint
- task: run-unit-tests
image: test-image
file: source/ci/tasks/test.yaml
Expand Down Expand Up @@ -206,11 +201,6 @@ jobs:
context: merge-conflict
status: failure
- do:
- task: run-lint
image: test-image
file: source/ci/tasks/test.yaml
params:
MAKE_TARGET: lint
- task: run-unit-tests
image: test-image
file: source/ci/tasks/test.yaml
Expand Down