Skip to content

Commit

Permalink
removed use of UserManagedSecrets flag for helm plugin repos (issue48…
Browse files Browse the repository at this point in the history
…70) (#5612)

### Description of the change

refactored helm plugin to not depend on a system flag
"UserManagedSecrets" but allow secrets to be managed by user or by
kubeapps per repository

### Benefits

provides ability for different users to either choose to provide
credentials or use existing credentials on per repository basis instead
of being forced one way or another by a system flag.

### Applicable issues
- fixes #4870
  • Loading branch information
dlaloue-vmware authored Nov 17, 2022
1 parent 4eb0f19 commit b146e91
Show file tree
Hide file tree
Showing 26 changed files with 1,889 additions and 2,039 deletions.
1 change: 0 additions & 1 deletion chart/kubeapps/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -463,7 +463,6 @@ Once you have installed Kubeapps follow the [Getting Started Guide](https://gith
| `kubeappsapis.pluginConfig.core.packages.v1alpha1.versionsInSummary.patch` | Number of patch versions to display in the summary | `3` |
| `kubeappsapis.pluginConfig.core.packages.v1alpha1.timeoutSeconds` | Value to wait for Kubernetes commands to complete | `300` |
| `kubeappsapis.pluginConfig.helm.packages.v1alpha1.globalPackagingNamespace` | Custom global packaging namespace. Using this value will override the current "kubeapps release namespace + suffix" pattern and will create a new namespace if not exists. | `""` |
| `kubeappsapis.pluginConfig.helm.packages.v1alpha1.userManagedSecrets` | Default policy for handling repository secrets, either managed by the user or by kubeapps-apis | `false` |
| `kubeappsapis.pluginConfig.kappController.packages.v1alpha1.defaultUpgradePolicy` | Default upgrade policy generating version constraints | `none` |
| `kubeappsapis.pluginConfig.kappController.packages.v1alpha1.defaultPrereleasesVersionSelection` | Default policy for allowing prereleases containing one of the identifiers | `nil` |
| `kubeappsapis.pluginConfig.kappController.packages.v1alpha1.defaultAllowDowngrades` | Default policy for allowing applications to be downgraded to previous versions | `false` |
Expand Down
2 changes: 0 additions & 2 deletions chart/kubeapps/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -1513,8 +1513,6 @@ kubeappsapis:
v1alpha1:
## @param kubeappsapis.pluginConfig.helm.packages.v1alpha1.globalPackagingNamespace Custom global packaging namespace. Using this value will override the current "kubeapps release namespace + suffix" pattern and will create a new namespace if not exists.
globalPackagingNamespace: ""
## @param kubeappsapis.pluginConfig.helm.packages.v1alpha1.userManagedSecrets Default policy for handling repository secrets, either managed by the user or by kubeapps-apis
userManagedSecrets: false
kappController:
packages:
v1alpha1:
Expand Down
8 changes: 0 additions & 8 deletions cmd/kubeapps-apis/docs/kubeapps-apis.swagger.json
Original file line number Diff line number Diff line change
Expand Up @@ -4134,14 +4134,6 @@
}
}
},
"pluginshelmpackagesv1alpha1SetUserManagedSecretsResponse": {
"type": "object",
"properties": {
"value": {
"type": "boolean"
}
}
},
"protobufAny": {
"type": "object",
"properties": {
Expand Down
2 changes: 1 addition & 1 deletion cmd/kubeapps-apis/gen/apidocs.pb.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

44 changes: 23 additions & 21 deletions cmd/kubeapps-apis/gen/core/packages/v1alpha1/packages.pb.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading

0 comments on commit b146e91

Please sign in to comment.